[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request: Make sure we always have at least one output enabled
From: Àlex_Fiestas <afiestas () kde ! org>
Date: 2013-01-02 9:52:55
Message-ID: 20130102095255.2548.14831 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108062/#review24418
-----------------------------------------------------------
Ship it!
Besides removing the kcm line, the patch looks fine.
- Àlex Fiestas
On Jan. 1, 2013, 8:35 p.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108062/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2013, 8:35 p.m.)
>
>
> Review request for Solid and Àlex Fiestas.
>
>
> Description
> -------
>
> When restoring a config, make sure that we have at least one output enabled. \
> There's nothing worse then ending up with all screens disabled (for users who don't \
> know how to use xrandr ;-)
> Fixes the issue that when you unplugging external monitor while laptop lid is \
> closed and open the lid, the laptop monitor is disabled.
>
> This addresses bug 312410.
> http://bugs.kde.org/show_bug.cgi?id=312410
>
>
> Diffs
> -----
>
> kcm/qml/OutputView.qml e12d526
> kded/generator.cpp 979e192
> tests/testgenerator.cpp 6dd3574
>
> Diff: http://git.reviewboard.kde.org/r/108062/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Vrátil
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108062/">http://git.reviewboard.kde.org/r/108062/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Besides removing the kcm \
line, the patch looks fine.</pre> <br />
<p>- Àlex</p>
<br />
<p>On January 1st, 2013, 8:35 p.m., Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2013, 8:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When restoring a config, make sure that we have at least one output \
enabled. There's nothing worse then ending up with all screens disabled (for \
users who don't know how to use xrandr ;-)
Fixes the issue that when you unplugging external monitor while laptop lid is closed \
and open the lid, the laptop monitor is disabled.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312410">312410</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcm/qml/OutputView.qml <span style="color: grey">(e12d526)</span></li>
<li>kded/generator.cpp <span style="color: grey">(979e192)</span></li>
<li>tests/testgenerator.cpp <span style="color: grey">(6dd3574)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108062/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic