[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request: Semantic change in XRandROutput::edid() and select the firs
From: Àlex_Fiestas <afiestas () kde ! org>
Date: 2012-12-30 14:35:10
Message-ID: 20121230143510.32589.24059 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107940/#review24255
-----------------------------------------------------------
Ship it!
Ship It!
- =C3=80lex Fiestas
On Dec. 27, 2012, 12:36 p.m., Lamarque Vieira Souza wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107940/
> -----------------------------------------------------------
> =
> (Updated Dec. 27, 2012, 12:36 p.m.)
> =
> =
> Review request for Solid, =C3=80lex Fiestas and Dan Vr=C3=A1til.
> =
> =
> Description
> -------
> =
> The change in XRandROutput::edid() allows us to use "if (edid->isValid())=
" instead of "if (edid && edid->isValid())". I think the former is cleaner.
> =
> The change in XRandROutput::updateModes() selects the first preferred mod=
e found instead of the last one. At least in my notebook the first preferre=
d mode has higher resolution, probably that is also valid for all modes ret=
urned by XRandR API.
> =
> =
> Diffs
> -----
> =
> backends/xrandr/xrandroutput.cpp dc2555b =
> =
> Diff: http://git.reviewboard.kde.org/r/107940/diff/
> =
> =
> Testing
> -------
> =
> Tested in my notebook. The change in XRandROutput::edid() is part of a cr=
ash fix for kscreen. The change in XRandROutput::updateModes() fixes a prob=
lem in my notebook's lcd, which includes several preferred modes and the la=
st mode is the one with lower resolution.
> =
> =
> Thanks,
> =
> Lamarque Vieira Souza
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107940/">http://git.reviewboard.kde.org/r/107940/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Àlex</p>
<br />
<p>On December 27th, 2012, 12:36 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid, Àlex Fiestas and Dan Vrátil.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2012, 12:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The change in XRandROutput::edid() allows us to use "if \
(edid->isValid())" instead of "if (edid && \
edid->isValid())". I think the former is cleaner.
The change in XRandROutput::updateModes() selects the first preferred mode found \
instead of the last one. At least in my notebook the first preferred mode has higher \
resolution, probably that is also valid for all modes returned by XRandR API.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in my notebook. The change in XRandROutput::edid() is part of a \
crash fix for kscreen. The change in XRandROutput::updateModes() fixes a problem in \
my notebook's lcd, which includes several preferred modes and the last mode is \
the one with lower resolution.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/xrandr/xrandroutput.cpp <span style="color: grey">(dc2555b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107940/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic