[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request: Fix removable property in soliddevice dataengine with HAL b
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2012-09-12 14:19:57
Message-ID: 20120912141957.19135.56086 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106378/#review18899
-----------------------------------------------------------
Ship it!
From where I stand, I see HAL as the official backend for freeBSD, no moder=
n linux distro (or any distro that will update their libsolid version) is s=
hipping with HAL.
So, if with this patch freeBSD support is better, please go ahead! =
- Alex Fiestas
On Sept. 8, 2012, 12:26 a.m., Alberto Villa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106378/
> -----------------------------------------------------------
> =
> (Updated Sept. 8, 2012, 12:26 a.m.)
> =
> =
> Review request for Solid.
> =
> =
> Description
> -------
> =
> Current hack to check for removable property in StorageAccess devices goe=
s up only one level to search for the StorageDrive device. This works fine =
with UDev, but not with HAL, which can have (at least on FreeBSD, where I'm=
testing it) a StorageVolume device in the middle. Going up the whole tree =
of the Block device ensures that we eventually get to the StorageDrive one =
to fetch the correct removable property.
> =
> While here, I'd like to ask why only removable is set (in a not so convin=
cing way, as a removable device can be non-hotpluggable as far as I know) i=
nstead of both removable and hotpluggable, as done few lines above.
> =
> If approved, I'd like to commit this also to 4.9.
> =
> =
> Diffs
> -----
> =
> plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp 86f123c =
> =
> Diff: http://git.reviewboard.kde.org/r/106378/diff/
> =
> =
> Testing
> -------
> =
> Tested successfully on FreeBSD 10-CURRENT r239665 with KDE SC 4.9.0: my U=
SB flash drives now appear in the device notifier plasmoid (and a console.l=
og() in the plasmoid itself confirms that the device now has the Removable =
property).
> =
> I also double-checked with a UDev-backed `solid-hardware list details` lo=
g that the logic correctly applies to UDev.
> =
> =
> Thanks,
> =
> Alberto Villa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106378/">http://git.reviewboard.kde.org/r/106378/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From where I stand, I \
see HAL as the official backend for freeBSD, no modern linux distro (or any distro \
that will update their libsolid version) is shipping with HAL.
So, if with this patch freeBSD support is better, please go ahead! </pre>
<br />
<p>- Alex</p>
<br />
<p>On September 8th, 2012, 12:26 a.m., Alberto Villa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid.</div>
<div>By Alberto Villa.</div>
<p style="color: grey;"><i>Updated Sept. 8, 2012, 12:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Current hack to check for removable property in StorageAccess devices \
goes up only one level to search for the StorageDrive device. This works fine with \
UDev, but not with HAL, which can have (at least on FreeBSD, where I'm testing \
it) a StorageVolume device in the middle. Going up the whole tree of the Block device \
ensures that we eventually get to the StorageDrive one to fetch the correct removable \
property.
While here, I'd like to ask why only removable is set (in a not so convincing \
way, as a removable device can be non-hotpluggable as far as I know) instead of both \
removable and hotpluggable, as done few lines above.
If approved, I'd like to commit this also to 4.9.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested successfully on FreeBSD 10-CURRENT r239665 with KDE SC 4.9.0: my \
USB flash drives now appear in the device notifier plasmoid (and a console.log() in \
the plasmoid itself confirms that the device now has the Removable property).
I also double-checked with a UDev-backed `solid-hardware list details` log that the \
logic correctly applies to UDev.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp <span style="color: \
grey">(86f123c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106378/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic