[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request: better handling of Removable property for volumes in solidd
From: "Alberto Villa" <avilla () freebsd ! org>
Date: 2012-09-09 9:20:29
Message-ID: 20120909092029.29817.89393 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105432/#review18707
-----------------------------------------------------------
If adding that to the Solid API is a problem (because of the KDE-Libs freez=
e), please consider my solution: https://git.reviewboard.kde.org/r/106378
Anyway, I agree that having a method to retrieve the parent StorageDrive is=
the best solution. Still, please check my patch for differences.
- Alberto Villa
On Sept. 9, 2012, 7:28 a.m., Andriy Gapon wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105432/
> -----------------------------------------------------------
> =
> (Updated Sept. 9, 2012, 7:28 a.m.)
> =
> =
> Review request for Plasma, Solid and Alberto Villa.
> =
> =
> Description
> -------
> =
> Currently the code in SolidDeviceEngine::populateDeviceData sets volume's=
Removable property in straightforward fashion:
> - tries to cast volume's (immediate) parent device to Solid::StorageDrive
> - if that succeeds, checks isHotpluggable() and isRemovable() properties =
of the parent
> The problem is that there could be intermediate devices in solid device h=
ierarchy between the volume and its Solid::StorageDrive ancestor, for examp=
le partition-type devices.
> =
> The proposed code walks up the hierarchy to try harder to find Solid::Sto=
rageDrive ancestor of a given device.
> =
> BTW, I think that getAncestorOfType() helper function introduced in the p=
roposed change can be useful for other code too, so it might make sense to =
nominate it for inclusion into Solid API.
> =
> =
> Diffs
> -----
> =
> plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp 608da25 =
> =
> Diff: http://git.reviewboard.kde.org/r/105432/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Andriy Gapon
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105432/">http://git.reviewboard.kde.org/r/105432/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If adding that to the \
Solid API is a problem (because of the KDE-Libs freeze), please consider my solution: \
https://git.reviewboard.kde.org/r/106378 Anyway, I agree that having a method to \
retrieve the parent StorageDrive is the best solution. Still, please check my patch \
for differences.</pre> <br />
<p>- Alberto</p>
<br />
<p>On September 9th, 2012, 7:28 a.m., Andriy Gapon wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Solid and Alberto Villa.</div>
<div>By Andriy Gapon.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2012, 7:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the code in SolidDeviceEngine::populateDeviceData sets \
volume's Removable property in straightforward fashion:
- tries to cast volume's (immediate) parent device to Solid::StorageDrive
- if that succeeds, checks isHotpluggable() and isRemovable() properties of the \
parent The problem is that there could be intermediate devices in solid device \
hierarchy between the volume and its Solid::StorageDrive ancestor, for example \
partition-type devices.
The proposed code walks up the hierarchy to try harder to find Solid::StorageDrive \
ancestor of a given device.
BTW, I think that getAncestorOfType() helper function introduced in the proposed \
change can be useful for other code too, so it might make sense to nominate it for \
inclusion into Solid API.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp <span style="color: \
grey">(608da25)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105432/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic