[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request: Make appShouldConserResources() reliable
From: "Daniel Nicoletti" <dantti85-kde () yahoo ! com ! br>
Date: 2012-06-20 23:19:04
Message-ID: 20120620231904.32568.45045 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 20, 2012, 10:29 p.m., Lamarque Vieira Souza wrote:
> > solid/solid/powermanagement.cpp, line 236
> > <http://git.reviewboard.kde.org/r/105310/diff/1/?file=69989#file69989line236>
> >
> > The famous default complaint: remove extra space, please.
> >
> > The rest of the code is Ok from my point of view, as long as you are right about \
> > the QDBusInterfaces are still valid if services disappears and reappears on the \
> > bus. Can you test that by restarting kded4? Use the kill -9 since it is a good \
> > way to similate a crash :-)
hehe, I noticed the white space as soon as I opened the diff here :P
(which is why I love QtCreator so much)
Well I tested killing kded and the application using the interface behaved as \
expected, which is why I said we didn't need new on this, tho now I remember having \
this issue too on Apper but maybe QDBusInterface got fixed... I'll perform another \
tests as well. BTW do you have any idea on why there is a weird connect on the \
register part? I think we could just connect the signal on the constructor if there's \
no such signal it will just fail.. ( I never saw an interface that can arbitrarily \
export signals, so it just seems wrong..)
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105310/#review14926
-----------------------------------------------------------
On June 20, 2012, 9:41 p.m., Daniel Nicoletti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105310/
> -----------------------------------------------------------
>
> (Updated June 20, 2012, 9:41 p.m.)
>
>
> Review request for Solid.
>
>
> Description
> -------
>
> Without this patch the appShouldConserResources() can't be trusted,
> if the DBus interface is not available or any other error occur
> we don't get the right values (normally it was true so Apper was
> prevented to check for new updates).
> This patch of course does fix other stuff which are related to the
> same problem.
>
>
> Diffs
> -----
>
> solid/solid/powermanagement.cpp 8dc8535
> solid/solid/powermanagement_p.h f39815d
>
> Diff: http://git.reviewboard.kde.org/r/105310/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Nicoletti
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105310/">http://git.reviewboard.kde.org/r/105310/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 20th, 2012, 10:29 p.m., <b>Lamarque Vieira \
Souza</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105310/diff/1/?file=69989#file69989line236" \
style="color: black; font-weight: bold; text-decoration: \
underline;">solid/solid/powermanagement.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Solid::PowerManagement::Notifier *Solid::PowerManagement::notifier()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">231</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The famous default \
complaint: remove extra space, please.
The rest of the code is Ok from my point of view, as long as you are right about the \
QDBusInterfaces are still valid if services disappears and reappears on the bus. Can \
you test that by restarting kded4? Use the kill -9 since it is a good way to similate \
a crash :-)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hehe, I \
noticed the white space as soon as I opened the diff here :P (which is why I love \
QtCreator so much) Well I tested killing kded and the application using the interface \
behaved as expected, which is why I said we didn't need new on this, tho now I \
remember having this issue too on Apper but maybe QDBusInterface got fixed... \
I'll perform another tests as well. BTW do you have any idea on why there is a \
weird connect on the register part? I think we could just connect the signal on the \
constructor if there's no such signal it will just fail.. ( I never saw an \
interface that can arbitrarily export signals, so it just seems wrong..)</pre>
<br />
<p>- Daniel</p>
<br />
<p>On June 20th, 2012, 9:41 p.m., Daniel Nicoletti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid.</div>
<div>By Daniel Nicoletti.</div>
<p style="color: grey;"><i>Updated June 20, 2012, 9:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Without this patch the appShouldConserResources() can't be trusted, \
if the DBus interface is not available or any other error occur we don't get the \
right values (normally it was true so Apper was prevented to check for new updates).
This patch of course does fix other stuff which are related to the
same problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/powermanagement.cpp <span style="color: grey">(8dc8535)</span></li>
<li>solid/solid/powermanagement_p.h <span style="color: grey">(f39815d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105310/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic