[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request: Make lid close explicit policy configurable
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2012-02-20 18:31:23
Message-ID: 20120220183123.31130.33469 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104001/#review10770
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Fiestas
On Feb. 20, 2012, 5:42 p.m., Dario Freddi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104001/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2012, 5:42 p.m.)
>
>
> Review request for Solid, Alex Fiestas and Albert Astals Cid.
>
>
> Description
> -------
>
> As description says. With this new option, users will be able to determine whether \
> lid close will be affected by inhibition or not. Albert, I CC'ed you to get an \
> exemption for string freeze on the two strings I added for 4.8.
>
> This addresses bug 289760.
> http://bugs.kde.org/show_bug.cgi?id=289760
>
>
> Diffs
> -----
>
> powerdevil/PowerDevilSettings.kcfg 5d50041
> powerdevil/daemon/actions/bundled/handlebuttonevents.h fa2e5ca
> powerdevil/daemon/actions/bundled/handlebuttonevents.cpp 6f4560f
> powerdevil/kcmodule/global/GeneralPage.cpp b7039b8
> powerdevil/kcmodule/global/generalPage.ui 0375e8f
>
> Diff: http://git.reviewboard.kde.org/r/104001/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dario Freddi
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104001/">http://git.reviewboard.kde.org/r/104001/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Alex</p>
<br />
<p>On February 20th, 2012, 5:42 p.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid, Alex Fiestas and Albert Astals Cid.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2012, 5:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As description says. With this new option, users will be able to \
determine whether lid close will be affected by inhibition or not. Albert, I \
CC'ed you to get an exemption for string freeze on the two strings I added for \
4.8.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289760">289760</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/PowerDevilSettings.kcfg <span style="color: \
grey">(5d50041)</span></li>
<li>powerdevil/daemon/actions/bundled/handlebuttonevents.h <span style="color: \
grey">(fa2e5ca)</span></li>
<li>powerdevil/daemon/actions/bundled/handlebuttonevents.cpp <span style="color: \
grey">(6f4560f)</span></li>
<li>powerdevil/kcmodule/global/GeneralPage.cpp <span style="color: \
grey">(b7039b8)</span></li>
<li>powerdevil/kcmodule/global/generalPage.ui <span style="color: \
grey">(0375e8f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104001/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic