'[Kde-hardware-devel] Review Request: Solid support for docking'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-hardware-devel
Subject:    [Kde-hardware-devel] Review Request: Solid support for docking
From:       "Will Stephenson" <wstephenson () kde ! org>
Date:       2010-09-24 15:59:37
Message-ID: 20100924155937.7470.58640 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5439/
-----------------------------------------------------------

Review request for Solid and Kevin Ottens.

Summary
-------

Solid support for laptop docks.  Should enable a fix for bko#185460.

This addresses bug 185460.
    https://bugs.kde.org/show_bug.cgi?id=185460

Diffs
-----

  trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1178599 
  trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakedevice.cpp 1178599 
  trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakedockstation.h PRE-CREATION 
  trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakedockstation.cpp PRE-CREATION 
  trunk/KDE/kdelibs/solid/solid/backends/hal/haldevice.cpp 1178599 
  trunk/KDE/kdelibs/solid/solid/backends/hal/haldeviceinterface.h 1178599 
  trunk/KDE/kdelibs/solid/solid/backends/hal/haldockstation.h PRE-CREATION 
  trunk/KDE/kdelibs/solid/solid/backends/hal/haldockstation.cpp PRE-CREATION 
  trunk/KDE/kdelibs/solid/solid/deviceinterface.h 1178599 
  trunk/KDE/kdelibs/solid/solid/dockstation.h PRE-CREATION 
  trunk/KDE/kdelibs/solid/solid/dockstation.cpp PRE-CREATION 
  trunk/KDE/kdelibs/solid/solid/dockstation_p.h PRE-CREATION 
  trunk/KDE/kdelibs/solid/solid/ifaces/dockstation.h PRE-CREATION 
  trunk/KDE/kdelibs/solid/solid/ifaces/dockstation.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/5439/diff

Testing
-------

Not enough, I need to get access to a dock.

Thanks,

Will

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5439/">http://svn.reviewboard.kde.org/r/5439/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Solid and Kevin Ottens.</div>
<div>By Will Stephenson.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Solid support for laptop docks.  Should enable a fix for \
bko#185460.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Not enough, I need to get access to a dock.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=185460">185460</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdelibs/solid/solid/CMakeLists.txt <span style="color: \
grey">(1178599)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakedevice.cpp <span style="color: \
grey">(1178599)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakedockstation.h <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakedockstation.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/backends/hal/haldevice.cpp <span style="color: \
grey">(1178599)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/backends/hal/haldeviceinterface.h <span \
style="color: grey">(1178599)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/backends/hal/haldockstation.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/backends/hal/haldockstation.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/deviceinterface.h <span style="color: \
grey">(1178599)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/dockstation.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/dockstation.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/dockstation_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/ifaces/dockstation.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/ifaces/dockstation.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5439/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[prev in list] [next in list] [prev in thread] [next in thread] 