From kde-hardware-devel  Tue Jul 07 23:57:28 2009
From: Kevin Ottens <ervin () kde ! org>
Date: Tue, 07 Jul 2009 23:57:28 +0000
To: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Making Solid give a visible name for
Message-Id: <200907080157.33287.ervin () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-hardware-devel&m=124701106808744
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1884531227=="

--===============1884531227==
Content-Type: multipart/signed;
  boundary="nextPart4510216.km3xUEvJaq";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart4510216.km3xUEvJaq
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

On Friday 17 April 2009 20:02:26 Albert Astals Cid wrote:
> > Well, looks like you're treating a symptom and not the cause in this
> > case, isn't it?
>
> Not really, my main issue is non translatability (i'm the i18n maintainer
> you know),

I rest my case.

> for example another problem is
>
>   vendor =3D ''  (string)
>   product =3D 'PC Floppy Drive'  (string)
>
> that should obviously be shown translated, that with my patch does not (a=
nd
> with your vendor + product does not)

This one is definitely troublesome. Would be good to translate it, I guess=
=20
it'll require special casing it... not pretty but will do the job.

I've been pondering asking you to hijack product() instead of introducing a=
=20
new method. But after all it's probably a bad idea as the behavior change=20
could prove to be a problem.

Please rename "visibleName()" to "description()" though (and the same for t=
he=20
backend methods which have a similar name). After that feel free to commit.

Thanks for taking care of this one and for the patience as this patch is qu=
ite=20
old now. :-)

Regards.
=2D-=20
K=E9vin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le ma=EEtre sans disciple, Ni le disciple sans ma=EEtre,
Ne font reculer l'ignorance."

--nextPart4510216.km3xUEvJaq
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkpT4O0ACgkQB0u7y43syeJobwCeJC1QGC2vkH5j/KoyJUOPvKHE
D4IAnj3ZEnB5+lQSVO9bkmjvCDtE24PD
=Ur4f
-----END PGP SIGNATURE-----

--nextPart4510216.km3xUEvJaq--

--===============1884531227==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

--===============1884531227==--