From kde-hardware-devel  Fri Apr 17 18:02:26 2009
From: Albert Astals Cid <aacid () kde ! org>
Date: Fri, 17 Apr 2009 18:02:26 +0000
To: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Making Solid give a visible name for
Message-Id: <200904172002.27476.aacid () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-hardware-devel&m=123999141127933
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-00=_zQM6Jm8taOt925M"

--Boundary-00=_zQM6Jm8taOt925M
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

A Divendres, 17 d'abril de 2009, Kevin Ottens va escriure:
> On Friday 10 April 2009 17:00:28 Albert Astals Cid wrote:
> > i'm attaching a patch that adds the visibleName function for Solid
> > devices, that is useful for places like the places viewer in dolphin or
> > the device notifier in plasma. Currently when i connect my phone i get
> > "Volume (fat32)" which sucks for two reasons:
> >  * It's not much detailed
>
> Which is the real issue.
>
> >  * Can't be translated
>
> Which is in my opinion a side effect of the real issue.
>
> > With the current patch, the "Can't be translated" part is fixed and now i
> > get "7,4 GiB External Media" that is not a great improvement but at least
> > can be translated.
>
> Well, looks like you're treating a symptom and not the cause in this case,
> isn't it? 

Not really, my main issue is non translatability (i'm the i18n maintainer you 
know), for example another problem is 

  vendor = ''  (string)
  product = 'PC Floppy Drive'  (string)

that should obviously be shown translated, that with my patch does not (and 
with your vendor + product does not)


> I'm not sold on the approach... We should probably try to instead
> report a better string in the first place, not something equally bad but
> translatable. I suspect the right fix would be in HAL, but that's maybe
> something we could workaround.

The right fix is already in HAL (libhal-storage) and is "the same code" i 
posted

> In any case we probably want to make sure vendor()+product() gives us
> something sensible, I'm not fan of having another method to call for that.

I'm not returning vendor+product, just vendor+model on the last resort of not 
finding anything that can identify the product.

>
> Could you provide your "solid-hardware list details" and solid-hardware
> list nonportableinfo" outputs with the phone connected? Bonus point if you
> give us the udi of the phone itself (makes it easier to look for the right
> info).

Yeah, but i don't care about my phone, i just care about having things 
translatable, my phone was just an example.

The volume udi is '/org/freedesktop/Hal/devices/volume_uuid_CDF2_6BE2'

Albert

>
> Regards.



--Boundary-00=_zQM6Jm8taOt925M
Content-Type: application/zip;
  charset="UTF-8";
  name="nonportable.txt.zip"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
	filename="nonportable.txt.zip"

UEsDBBQAAAAIAIc7R/x/kfA+qQMAAKsbAAAPAAAAbm9ucG9ydGFibGUudHh0vVhLb+M2EL73V+xt
jyYpkpIPPThRgxTbzQb1tkFPA4qkUiGypeqx6PbXl/IjteNgd0ZSGiCGnOj7+M1wXmTvinc/vnu/
qJrHRd5473z71FX14taUC+e/FNa3iy9V2W889H3h4Dq9EaCvfhLvf+gR0LarGvPoofVNYUq4q54K
A2vNIFKSJxETQshEqSUwYDjGvs1g/wxScOBKX3AVOYPWtgX8WbUdHJ4PmLLfHv7w6LdBlP3fVn2r
hd6Gd07WubhwPLUtgDMmQGUhzlyzgSZiDKxpHFLJ1nfAQ5RzUAqshMxCgoyTujRdXoU187Kq669D
GBwy4MV/cHSHzKtN00XQFv/4YJmQOKytNnXf+Ya00i7HjeFGaSVBOWPDZuQGTMIcLJn00mrjEpvQ
WUVkEp1JDdrmCUgrIkjyQJ35TAvnciti5P6csUrNuVg6iJWKQQ6CjWYxaMOTxAexWnM6K1+lLL26
2X2myxQbedsa7u/umWL8WPCedx1p2jFaNpXzJaS/p78+wC+3wJMVvx3JAOtPtylwHX+mxQ2YsjXQ
FRtsCD3bWiRMisPnh6sU6qrpoKweC2vK8DIU27AAUUzVtsGnf/V+a8M3pDdfR49xw1jwS6sBGYx1
PUBC3g++I8bOIfTWq88reEivw69ijK1WH9YQnuHh42r9h+RLHXNkFu8rqvOgopPGc9FVx/RVJPUU
4iW0Vb91uwYQNO62M4Tq18zYJ0COMd9ms6bu+saj9xYnDbnrOGlTyYYE2hR/h4iebOVAVdsNfuL7
joXVtmuqckZdM/Eg9ZyOPTqQMBnBtjrk8DCSjSuced963JvG1gXcrO4Ib1/f/4b00vF1pDOGyeuk
dlb1kAnE7lPbtn66rLx4AWFY5ApyAZEMswoskX58CY0daHJ5UfTJ/lUwFSrfqvpeEE9VR/bKRWMZ
oyCaouC8QEydIKYS0GZZy7B19Rkg0KV4D8mYyIkApmmiIhbRAJJqtqICYoaNo2fHIg9+R0BCXSGj
AgTdBoFOn/8gNIBh2LH22DH2zTYRCivtvNXMcDoaQzHyQoIIuwlDn4OP6c+fIOtbWu0ToRJwdOad
QEhtcw8hTX97CMmW3X0S9oLi7AqK2i0c/VDi6MMvuhGdQKiAmADgJgMZCZIoaSFhghRfgyzyDKPm
nKYmcJGh8x7v52SbwEWGksc18sGNO51B6GzhZzgCDBPQqHvvV3io4rN5Tp3TWcYZz0+NZ+OdeM5D
daKhAsgVmywpHEL/BVBLAQIUAxQAAAAIAIc7R/x/kfA+qQMAAKsbAAAPAAkAAAAAAAAAAACkgQAA
AABub25wb3J0YWJsZS50eHRVVAUAB/////9QSwUGAAAAAAEAAQBGAAAA1gMAAAAA

--Boundary-00=_zQM6Jm8taOt925M
Content-Type: application/zip;
  charset="UTF-8";
  name="details.txt.zip"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
	filename="details.txt.zip"

UEsDBBQAAAAIAIc7R/y4366ofQ4AAKKFAAALAAAAZGV0YWlscy50eHTtXVtzozgWfp9foZetpGvH
DmDAOFX74NhJx9tx4mon3T01NaUSIMdsMGK55LKb/e8rCXwHxwhiO9Mz00mcIKRzdD6dqwSx7YB/
gKMTEtyfjAKMbRw+RMQ/uUTuiY0fHQuHJ4/EjScYxrFjw073QoH62bly9AsAPgqwF715fxiRAN1j
GOLAQS68Jg8OgkNdgg1NlY2GpCiKamhaC0pQOgLgOIwCx7v/RAd4xJ5NAjbA8t/9gNixxUf+xokD
x48jFH1abnXmEuuhPkH/4l0Y9Jr0bHyiPxwvWrjuePy6rPMGsrTWIuGDs0k/noS2uTzOMOGvbVFm
wzriPxzTZXeMkBti2tgkxF1vOnJcPEDReJ3BtF3CXN25pyRiO7+/tF0c0s+sswva8fAljPDkiDOl
MJ6wF0/W7xmFty8+v4nN4CYqXGRi9y1SGUhYG4aTGsfJhsah8x8+crOlt+RmU5eWxP9LvAU2C2Fr
e8jGoQmTz1BVZChr+lqHzkiCoRU6cEzCCKaf03vc2MtFMicxF86U9L2CuBs4j7huxiFreReaCX7k
DPwkLW32fYqgSxTYXSd8SG6Scm8K8IQ8omSFREGcAeik3ZhEvhvf32c3HZAgYlf62HbQwEUvOKiH
se/TP2N7EJCIWMRlfPz3KEXJ0f9mLAPXCaM3e+FkBLyPtVu3gmcFOEr+cI89inDrMCCcj97OsAc+
J6SCnhfhYIQsXHhRV0H6e06U2Lx0+Rg7mIzKeRfj95ISA9o28ikM3p3rn4fnSjktzOXd8Az0URhO
FfW7rnIxVmVbN6ECJfofZP8UKG+0xaBPTOovgcGYeDjM5TxpqxmSBH74AXXf+nFIFXJRrn3LgbJE
idJM6qXYwQQGDUqlRU1nEdEudZPHXvu2B26xNfaIS+4dHFJhWbn8dZ0A009f6d2Ym7k+8qiAA1G9
5eEIyjRWkKGmQUuFpgWNIvbLIhM/XllGW0H0LHDsPGACcI2jJxI8zK7WHfb9Gk24B+OjVau31v6J
zpNLxZ/hja+1HT+1bTtIGh/Jyqkun2raqaWemtapYb0x0ARZC3cXd419F0UjQgE2convvzAjmTrL
K1eKwG61z8LSGXTABb8XcOdqk7OrzGOXTGdXmruZm1zdkb1CZSXx2smEOYwnyTxkD7DqS78OUYRe
B+kUJk6ytp1nnUxZfjBXyq9eZnorbKUpAYqaqAFZGEeVkaKK5wSG7ds2/N7t0C+N6u12+8sQ0s/w
e789/E2VW3pTNgRTA2XCqQa/3ng7mEKNSuP3Oy8Osf06D+NfB3Smncgh3i0T2tGcrrei+soi+m0C
eQ6ConpqpuiX0FNY2p0Me1EEyzy9hZCMNF1ToWYji7olIwSRIdmwJalYtXRkG5ZxkCinF5+QXyoB
1uTXm1uAvVkp2G+icSK17JTBGqIZo5WheirwGhN4jQm8xgReWxL4FshXpFZTlen/xfG/iD+lgQzd
VHWoWyMDqpbSgMaIgtDEpq7Y9shSmkW8xF3g729jUk7JJikrfQvc6Vvb8Wzrl2XG16nPg3N2n5Wk
XvFztNGAzCCdMdnZuJ4CqcaAVGNAqjEg1ZaAtAWu1YYmtRRdatAFUQ7Zqi7LSsuGTU1rQpWpV6RL
Tagj2TAwXWm6Lh8YsqealUmnlGbV5q7eGwjX3gHhHwfdWwE7xVGN4ajGcFRjOKot4WgrV0U1mnKL
au1yuJbbXal7dsG/d1vdIjmLXWLYi0ZhKQznBWPrGM4u+ZTDcBJs0c43ynY3dTI2lbXGfWWIXkPQ
FujVFFVptqi3rRdHr+/5cHA9kDRJnkJvFtYXSkHN+ykMS1nXNKldY64/ijgaOjd9wIouwhXACbGx
C7vful+/w6tLKBtt+bJwQs3GUGss5NLXijG5CY+r3u157eY6P73GCANXl7WEsA0rUZY5Fs38Ih+Y
1eQ2LsUge7FUmJbo2AGZzPI4m+qElaQmALjxI8dCbtJ2VqbjtbuUnlf69fTafbTZV8C/8V8DNGE/
aOdhMPvwNP1kuykDoxFjYeSi+7XhAozsoY+5fjFUPQmXFFleTA8s3fAUOBEWvCNcXT5iawEOby67
UNabt5UvhRILATCqapyqMutgy/xfGLx7eu7Q1gFFdUKI+k5oXp/6SnE8TQlByjaCkTNZzQ69T+Wg
fTVsg1s2WkbRA4A2JZ3M8/McAUmdhVKZkcDIbH+JPNvNyMytNPbSgsRmCjiRUxDeeQ8eefKW27CL
C6RNobDSUUhiz2YlqGlf/JKH3OH0whp7xUoQjiGpSvr9y1kXMrxCVpSikKGNoeNRiYnUIbI6Li73
W3AbIC+knVJ0D3FEvd0H/GKSlPEFDRVHEfHqUTpNA/KEg+Rvr0MXYz/9nIoi+W0ugqWEbdrVGIXD
iI6bscjTFiG7/A25sWCufraYSBhSh+/fMfYs+lsRV094Rd0Mh3Q+0yGLLaobH3scfosOulxgfSXK
fzq48hMst2xJ/1xy/pnEzK3jTuXMLaSgoP+ykm/Jc9UgwiIZUWGZ9pFFfTgSjsGExNS4mNzsADyJ
qT10iFc8weAzDijZzBiLZBRUgYzCAAXIdbHLN3SK7lkRyciJxFWqQFxFacllntII5jTWSm0h3jaq
slc2MVcfVYlsJ85J/FW172HbLJHopt2yWahchFS0M3dL+t6V+/3z3oLcFPBNe1TW3AzTiOTFRNYD
LHIyJq/Lwixef3NY6N/5QgMhUAO9805LMwC31oOUsIMx1ku0PjnRmNLZMTQJHGdy8amAcecXb+KI
BZPr+Y9dBb0bcWIhP4oDXMi0vxdM+r0OaFPTwXHSSQj7eDBJuSiMk543g4lycDCZqZPim4KrxslH
1iJ/UuVxIKD4mCrjT6MoWJZn4jzTwPEArAnLAHWIFwXE3Uf+h8/DPkGS8r5A/iHBxLcmBU/Avh9K
Bp3+PhBih/7elcjrmo3RDwkpiY1JgHwIOmVx9hODI6Jg9mJw/oz6Y+942KP2QKzNX/pjO6TsX3Ps
Eyl/GZqsE746FaykNqBH0uQ6O75dYgfAW30Xxs8VpSXC1hjcDc9qg+GJMt3SAvqsLFI4XThiN4ms
A1yY9MK0Ict34EX7ehflpQtUvILE6esM7nayR6Hd74J2NHaJdxxNPgFdBT8U0I2p4DuEBreDgLD9
yLQTVZGkvy93M7tYp6vCxNn1k3mjCXqe7qA6kvJ6spDXGSPvHl8ESaH1JaOuMW/ueLQTyopDvCGO
eNnlmpw/R9gL6Z/CtbJmIQHspABZsQDWt8d+QAGw0/MLdWHis+TbLoRxlY4F0nqf0DF6l7zRWvgQ
vSSdLv97Y6DKDtH7Vug/rJfoRfasJV0Vr3B3AMUuehA44srQJElQ1uBIgQ0V6hZsiRmnZmGyU5HQ
C2JYwtH43R7JQBEka6cj5bShnurWaestwpbR1FIVrWk0NFnXS0ukaUO9cOVQRiZUG4qAr1xeJvIu
ZNK0T3VFRCYtVTOKr/UZyjXBxykt9CBWpS71/KBM+j8g9Zt2x5TfWiCy92Z3WwvWqBOW4UJPByNN
sbWk7pX+ta0owhJpHIhEGqUl0tgr/SuJIqFcU3WJaZ4jAZ2VowIlN37uJPDlpxfSUwbguNNfPR+c
e9YhIzO2+9MMJTzximbs4uJDzNh0V60l7SSaT5Kn4Gz18ExBWpXdbH7mthu5oNcFNDYD1I3EwSPz
i+knEge0b8CSAA47Vm6+gIE3ABPCHljDDwfRa/cOZTcI6+D4mkTToDn0seWMHKv+SXQGTEkZ7YL/
fxIqLsd6OPnMXHuhA9gziiV9J9vVB3eqJIP50XFhkDWkxi4I7p31wbk3Rp5FMXQsS/KJLCm1B/zy
K+Bp5mTXfXqIUxgwfNP8Drg57wzorw5zdUvBhT82YAf0VvikgSnlTWk35rkDqOr3bKZnkscMAtsJ
H0BaoHdFfKiZei3yrL4SJ0uom9Qh/jRVKkyvsZsZb9/WwujF5fqb5dkA9zOFqTZ3RTX4ipFbYweX
QYed1RCmWNkZxd3+bDdHOSAru/GVD9VPYDPwU/OPpCJHsMSVMWUo2UwAjtNhBWieVgCSMrWhaLsx
JOmwMwbmw5fgIa1i7IP+ZOgStGc+NUCgksN7KMwPvwvQcQXdkOXR9yEAPnKJ+Z89PXofxCeD18tg
/8J5xjbsd3s30IzDPfHBiQCMCECJEOKH58MUGmrLlYZCbfsxiXb6jhWQlOAQ/N7ud//I5e+LQRvw
XQC6enLDUoTE+4P2EFrYdZGHaZQEFjZJCjNa5YqpkNHu13a/lEe0wGKVgVWFLE7LdP3l5/cWZq/K
5VYhe5cvPg74c2SYWp+/eOGFiXXk3MeB4HH6+aseCj38d57ttmGukSr0ioiv3xpNCfz+FdmYeOBH
Q5KG53+U4Uc/BH60M32ZKerhdXrnn0Q5m1JYHUi9tPZA2BMV1kC0xFJSn2D0g+Q9GKWYqFKR7I2J
KtXFvpj4+Cw098nCOYtEPRyVNrCzHTciasvK46ePgkfq5CyajM8BiX1wFdn1XNYM49yQJBl8du6R
6UTVMSmpFjQkpYhHuAWTt/gZMXVMr8UT2mf+m5Zuh2dqo32mKCdt0Ds/P6/JjZaKaopEVfOcN6ql
L387uXK8B1HHNyF3vyur/MLS9snBkGcSQPu2XDZvu805InAsvQsm8QirYekD7n6psk6wd3S98Uwd
EemU3tNTGl8bH5Xz4Vn6gNuTqsykFF4yve55CdKLvL2gctLbnaNWMzmaVma5b34TpPgbNAu8VjKX
Ufb2zMvYrOalmVkEiawWM48N6lvFz+CC1UA3y0+pSyAgJALj2CyBPnOf6GOiqQZ12ccRhTC31pUY
4nrdil7TukaO+EqSF4Gb/zD59FDmryyPkx8K9X/QmAxcIUqV4GnNzeSV1Brb8bpDrbFCkIjWQKW1
hlyXq9Aa6ANrjTkXe00XDvtncViC+L1m2HrDdvkgushhuMo56OMJCV7ycPR/UEsBAhQDFAAAAAgA
hztH/Ljfrqh9DgAAooUAAAsACQAAAAAAAAAAAKSBAAAAAGRldGFpbHMudHh0VVQFAAf/////UEsF
BgAAAAABAAEAQgAAAKYOAAAAAA==

--Boundary-00=_zQM6Jm8taOt925M
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

--Boundary-00=_zQM6Jm8taOt925M--