'Re: [Kde-graphics-devel] Review Request 122734: Fix build warnings - KRun::run deprecated for servic'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-graphics-devel
Subject:    Re: [Kde-graphics-devel] Review Request 122734: Fix build warnings - KRun::run deprecated for servic
From:       "Boudhayan Gupta" <me () BaloneyGeek ! com>
Date:       2015-02-28 11:27:17
Message-ID: 20150228112717.12883.71884 () probe ! kde ! org
[Download RAW message or body]

--===============3542834094321620133==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122734/
-----------------------------------------------------------

(Updated Feb. 28, 2015, 11:27 a.m.)

Status
------

This change has been marked as submitted.

Review request for KSnapshot.

Repository: ksnapshot

Description
-------

In KF5, KRun::run is deprecated for services in favor of KRun::runService. This \
one-liner fixes that. Additionally, in the same line, the return value is saved to a \
bool variable which is checked with a Q_ASSERT macro; in Release builds this results \
in a warning about unused variables. This patch adds a Q_UNUSED macro after the \
Q_ASSERT macro to fix that.

Diffs
-----

  ksnapshot.cpp fe9c1e2 

Diff: https://git.reviewboard.kde.org/r/122734/diff/

Testing
-------

Build warnings are gone, no errors. Runs fine, takes screenshots fine. The 'Q' key \
shortcut to automatically take and save a screenshot also works.

My distribution (Arch) does not have KF5Kipi yet - all testing was done with Kipi \
disabled.

Thanks,

Boudhayan Gupta

--===============3542834094321620133==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122734/">https://git.reviewboard.kde.org/r/122734/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KSnapshot.</div>
<div>By Boudhayan Gupta.</div>

<p style="color: grey;"><i>Updated Feb. 28, 2015, 11:27 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In KF5, KRun::run is deprecated for services in favor of \
KRun::runService. This one-liner fixes that. Additionally, in the same line, the \
return value is saved to a bool variable which is checked with a Q_ASSERT macro; in \
Release builds this results in a warning about unused variables. This patch adds a \
Q_UNUSED macro after the Q_ASSERT macro to fix that.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build warnings are gone, no errors. Runs fine, takes \
screenshots fine. The 'Q' key shortcut to automatically take and save a screenshot \
also works.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">My distribution (Arch) does not have KF5Kipi yet - all \
testing was done with Kipi disabled.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksnapshot.cpp <span style="color: grey">(fe9c1e2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122734/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3542834094321620133==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-graphics-devel mailing list
Kde-graphics-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-graphics-devel

[prev in list] [next in list] [prev in thread] [next in thread] 