'[Kde-graphics-devel] Review Request 122737: Re-origanise code in the frameworks branch'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-graphics-devel
Subject:    [Kde-graphics-devel] Review Request 122737: Re-origanise code in the frameworks branch
From:       "Boudhayan Gupta" <me () BaloneyGeek ! com>
Date:       2015-02-27 10:02:56
Message-ID: 20150227100256.12883.90160 () probe ! kde ! org
[Download RAW message or body]

--===============8736522948864072991==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122737/
-----------------------------------------------------------

Review request for KSnapshot and Aleix Pol Gonzalez.

Repository: ksnapshot

Description
-------

This is a pretty big patch. It does the following:

* Move all the .cpp and .h files to an "src" directory
* Move the XDG desktop file to a "desktop" directory
* Move the SVG icon source for the hicolor icon to the icons directory
* Refactor the CMakeLists.txt file
* Give each subdirectory (src, icons, desktop) its own CMakeLists.txt. doc already \
                had one.
* Guard config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor \
                directives
* Move the KSNAPVERSION define from main.cpp to config-ksnapshot.h.cmake
* The KSnapshot version is now defined in the top-level CMakeLists.txt

Diffs
-----

  kipiinterface.h 8d866ef 
  kipiinterface.cpp 4d32647 
  ksnapshot.h 71ecd6f 
  ksnapshot.cpp 55e93ee 
  ksnapshot_options.h 36ab496 
  ksnapshotimagecollectionshared.h 6cc6d9b 
  ksnapshotimagecollectionshared.cpp da097f0 
  ksnapshotinfoshared.h b69423d 
  ksnapshotinfoshared.cpp 5892adb 
  ksnapshotobject.h a69253c 
  ksnapshotobject.cpp 06a8546 
  ksnapshotpreview.h 83ddf55 
  ksnapshotpreview.cpp 50bda19 
  ksnapshotsendtoactions.h f0b4f8f 
  ksnapshotsendtoactions.cpp a8c4ccb 
  ksnapshotwidget.ui c9b4258 
  main.cpp ef03554 
  org.kde.ksnapshot.desktop fdc8831 
  org.kde.ksnapshot.xml eb1d8e0 
  platforms/windows/windowgrabber.cpp 8cf1225 
  platforms/xcb/pixmaphelper.h e3f5695 
  platforms/xcb/pixmaphelper.cpp 92fb91d 
  platforms/xcb/windowgrabber.cpp 5de9473 
  platforms/xcb/xcbutils.h b57b692 
  regiongrabber.h 2cf9c40 
  regiongrabber.cpp 97af3fc 
  snapshottimer.h 93dc15c 
  snapshottimer.cpp 5cc3de2 
  src/.directory PRE-CREATION 
  src/CMakeLists.txt PRE-CREATION 
  src/Messages-i18n.sh PRE-CREATION 
  src/Messages-qt.sh PRE-CREATION 
  src/config-ksnapshot.h.cmake PRE-CREATION 
  src/expblur.cpp PRE-CREATION 
  src/freeregiongrabber.h PRE-CREATION 
  src/freeregiongrabber.cpp PRE-CREATION 
  src/kbackgroundsnapshot.h PRE-CREATION 
  src/kbackgroundsnapshot.cpp PRE-CREATION 
  src/kipiimagecollectionselector.h PRE-CREATION 
  src/kipiimagecollectionselector.cpp PRE-CREATION 
  src/kipiinterface.h PRE-CREATION 
  src/kipiinterface.cpp PRE-CREATION 
  src/ksnapshot.h PRE-CREATION 
  src/ksnapshot.cpp PRE-CREATION 
  src/ksnapshot_options.h PRE-CREATION 
  src/ksnapshotimagecollectionshared.h PRE-CREATION 
  src/ksnapshotimagecollectionshared.cpp PRE-CREATION 
  src/ksnapshotinfoshared.h PRE-CREATION 
  src/ksnapshotinfoshared.cpp PRE-CREATION 
  src/ksnapshotobject.h PRE-CREATION 
  src/ksnapshotobject.cpp PRE-CREATION 
  src/ksnapshotpreview.h PRE-CREATION 
  src/ksnapshotpreview.cpp PRE-CREATION 
  src/ksnapshotsendtoactions.h PRE-CREATION 
  src/ksnapshotsendtoactions.cpp PRE-CREATION 
  src/ksnapshotwidget.ui PRE-CREATION 
  src/main.cpp PRE-CREATION 
  src/org.kde.ksnapshot.xml PRE-CREATION 
  src/platforms/windows/windowgrabber.cpp PRE-CREATION 
  src/platforms/xcb/pixmaphelper.h PRE-CREATION 
  src/platforms/xcb/pixmaphelper.cpp PRE-CREATION 
  src/platforms/xcb/windowgrabber.cpp PRE-CREATION 
  src/platforms/xcb/xcbutils.h PRE-CREATION 
  src/regiongrabber.h PRE-CREATION 
  src/regiongrabber.cpp PRE-CREATION 
  src/snapshottimer.h PRE-CREATION 
  src/snapshottimer.cpp PRE-CREATION 
  src/windowgrabber.h PRE-CREATION 
  src/windowgrabber.cpp PRE-CREATION 
  windowgrabber.h f8c0b17 
  windowgrabber.cpp 4672679 
  CMakeLists.txt d174abf 
  Messages.sh d242e38 
  config-ksnapshot.h.cmake 3514dd5 
  desktop/CMakeLists.txt PRE-CREATION 
  desktop/org.kde.ksnapshot.desktop PRE-CREATION 
  expblur.cpp 173b1d7 
  freeregiongrabber.h 4f8e695 
  freeregiongrabber.cpp c60b0ca 
  hisc-app-ksnapshot.svgz 33ab303 
  icons/CMakeLists.txt PRE-CREATION 
  icons/hisc-app-ksnapshot.svgz PRE-CREATION 
  kbackgroundsnapshot.h 7289e63 
  kbackgroundsnapshot.cpp 8aefbb3 
  kipiimagecollectionselector.h 03a13c3 
  kipiimagecollectionselector.cpp 78c2ca6 

Diff: https://git.reviewboard.kde.org/r/122737/diff/

Testing
-------

Builds and installs fine. No functionality was added in this patch, so didn't test \
much beyond build/run/take screenshots.

Thanks,

Boudhayan Gupta

--===============8736522948864072991==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122737/">https://git.reviewboard.kde.org/r/122737/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KSnapshot and Aleix Pol Gonzalez.</div>
<div>By Boudhayan Gupta.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a pretty big patch. It does the following:</p> \
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Move all the .cpp and .h files to an \
"src" directory</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Move the XDG desktop file to a "desktop" \
directory</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Move the SVG icon source for the hicolor icon to the \
icons directory</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Refactor the CMakeLists.txt file</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Give each subdirectory (src, icons, desktop) its own \
CMakeLists.txt. doc already had one.</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Guard \
config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor \
directives</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Move the KSNAPVERSION define from main.cpp to \
config-ksnapshot.h.cmake</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">The KSnapshot version is now defined in \
the top-level CMakeLists.txt</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds and installs fine. No functionality was added \
in this patch, so didn't test much beyond build/run/take screenshots.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kipiinterface.h <span style="color: grey">(8d866ef)</span></li>

 <li>kipiinterface.cpp <span style="color: grey">(4d32647)</span></li>

 <li>ksnapshot.h <span style="color: grey">(71ecd6f)</span></li>

 <li>ksnapshot.cpp <span style="color: grey">(55e93ee)</span></li>

 <li>ksnapshot_options.h <span style="color: grey">(36ab496)</span></li>

 <li>ksnapshotimagecollectionshared.h <span style="color: grey">(6cc6d9b)</span></li>

 <li>ksnapshotimagecollectionshared.cpp <span style="color: \
grey">(da097f0)</span></li>

 <li>ksnapshotinfoshared.h <span style="color: grey">(b69423d)</span></li>

 <li>ksnapshotinfoshared.cpp <span style="color: grey">(5892adb)</span></li>

 <li>ksnapshotobject.h <span style="color: grey">(a69253c)</span></li>

 <li>ksnapshotobject.cpp <span style="color: grey">(06a8546)</span></li>

 <li>ksnapshotpreview.h <span style="color: grey">(83ddf55)</span></li>

 <li>ksnapshotpreview.cpp <span style="color: grey">(50bda19)</span></li>

 <li>ksnapshotsendtoactions.h <span style="color: grey">(f0b4f8f)</span></li>

 <li>ksnapshotsendtoactions.cpp <span style="color: grey">(a8c4ccb)</span></li>

 <li>ksnapshotwidget.ui <span style="color: grey">(c9b4258)</span></li>

 <li>main.cpp <span style="color: grey">(ef03554)</span></li>

 <li>org.kde.ksnapshot.desktop <span style="color: grey">(fdc8831)</span></li>

 <li>org.kde.ksnapshot.xml <span style="color: grey">(eb1d8e0)</span></li>

 <li>platforms/windows/windowgrabber.cpp <span style="color: \
grey">(8cf1225)</span></li>

 <li>platforms/xcb/pixmaphelper.h <span style="color: grey">(e3f5695)</span></li>

 <li>platforms/xcb/pixmaphelper.cpp <span style="color: grey">(92fb91d)</span></li>

 <li>platforms/xcb/windowgrabber.cpp <span style="color: grey">(5de9473)</span></li>

 <li>platforms/xcb/xcbutils.h <span style="color: grey">(b57b692)</span></li>

 <li>regiongrabber.h <span style="color: grey">(2cf9c40)</span></li>

 <li>regiongrabber.cpp <span style="color: grey">(97af3fc)</span></li>

 <li>snapshottimer.h <span style="color: grey">(93dc15c)</span></li>

 <li>snapshottimer.cpp <span style="color: grey">(5cc3de2)</span></li>

 <li>src/.directory <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/Messages-i18n.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/Messages-qt.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/config-ksnapshot.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/expblur.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/freeregiongrabber.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/freeregiongrabber.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/kbackgroundsnapshot.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/kbackgroundsnapshot.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/kipiimagecollectionselector.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kipiimagecollectionselector.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kipiinterface.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/kipiinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshot.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshot.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshot_options.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotimagecollectionshared.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotimagecollectionshared.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotinfoshared.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotinfoshared.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotobject.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotobject.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotpreview.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotpreview.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotsendtoactions.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotsendtoactions.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/ksnapshotwidget.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/org.kde.ksnapshot.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/platforms/windows/windowgrabber.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/platforms/xcb/pixmaphelper.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/platforms/xcb/pixmaphelper.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/platforms/xcb/windowgrabber.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/platforms/xcb/xcbutils.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/regiongrabber.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/regiongrabber.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/snapshottimer.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/snapshottimer.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/windowgrabber.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/windowgrabber.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>windowgrabber.h <span style="color: grey">(f8c0b17)</span></li>

 <li>windowgrabber.cpp <span style="color: grey">(4672679)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(d174abf)</span></li>

 <li>Messages.sh <span style="color: grey">(d242e38)</span></li>

 <li>config-ksnapshot.h.cmake <span style="color: grey">(3514dd5)</span></li>

 <li>desktop/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>desktop/org.kde.ksnapshot.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>expblur.cpp <span style="color: grey">(173b1d7)</span></li>

 <li>freeregiongrabber.h <span style="color: grey">(4f8e695)</span></li>

 <li>freeregiongrabber.cpp <span style="color: grey">(c60b0ca)</span></li>

 <li>hisc-app-ksnapshot.svgz <span style="color: grey">(33ab303)</span></li>

 <li>icons/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>icons/hisc-app-ksnapshot.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kbackgroundsnapshot.h <span style="color: grey">(7289e63)</span></li>

 <li>kbackgroundsnapshot.cpp <span style="color: grey">(8aefbb3)</span></li>

 <li>kipiimagecollectionselector.h <span style="color: grey">(03a13c3)</span></li>

 <li>kipiimagecollectionselector.cpp <span style="color: grey">(78c2ca6)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122737/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8736522948864072991==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-graphics-devel mailing list
Kde-graphics-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-graphics-devel

[prev in list] [next in list] [prev in thread] [next in thread] 