'Re: [Kde-graphics-devel] Review Request 122719: Make KSnapshot handle high DPI support'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-graphics-devel
Subject:    Re: [Kde-graphics-devel] Review Request 122719: Make KSnapshot handle high DPI support
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2015-02-25 15:35:25
Message-ID: 20150225153525.12883.27522 () probe ! kde ! org
[Download RAW message or body]

--===============3971115231107144749==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122719/#review76614
-----------------------------------------------------------

Ship it!

Ship It!

- Aleix Pol Gonzalez

On Feb. 25, 2015, 3:31 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122719/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 3:31 p.m.)
> 
> 
> Review request for KDE Graphics and KSnapshot.
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> -------
> 
> The preview did some custom painting which needed adjusting to generate
> a pixmap at a higher devicePixelRatio
> 
> 
> Diffs
> -----
> 
> main.cpp 84cf9f8 
> ksnapshotpreview.cpp 4abe4ff 
> 
> Diff: https://git.reviewboard.kde.org/r/122719/diff/
> 
> 
> Testing
> -------
> 
> Ran with QT_DEVICE_PIXEL_RATIO=2
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============3971115231107144749==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122719/">https://git.reviewboard.kde.org/r/122719/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On February 25th, 2015, 3:31 p.m. CET, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Graphics and KSnapshot.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Feb. 25, 2015, 3:31 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The preview did some custom painting which needed \
adjusting to generate a pixmap at a higher devicePixelRatio</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran with QT_DEVICE_PIXEL_RATIO=2</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>main.cpp <span style="color: grey">(84cf9f8)</span></li>

 <li>ksnapshotpreview.cpp <span style="color: grey">(4abe4ff)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122719/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3971115231107144749==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-graphics-devel mailing list
Kde-graphics-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-graphics-devel

[prev in list] [next in list] [prev in thread] [next in thread] 