[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-graphics-devel
Subject: Re: [Kde-graphics-devel] Review Request 110349: KSnapshot: Do not open unexistent files
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2014-09-15 8:44:09
Message-ID: 20140915084409.22584.83971 () probe ! kde ! org
[Download RAW message or body]
--===============0910357216761194221==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110349/#review66524
-----------------------------------------------------------
thanks, but this is not quite the right fix. i've pushed a fix to the frameworks \
branch where current devel is happening. cheers, and thanks for taking the time to \
make a patch and submit it; it's what brought the issue to my attention (i just took \
over maintainership of the app so am catching up here still :)
- Aaron J. Seigo
On May 15, 2013, 2:20 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110349/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 2:20 p.m.)
>
>
> Review request for KDE Graphics, Aaron J. Seigo and Richard Moore.
>
>
> Bugs: 258431
> http://bugs.kde.org/show_bug.cgi?id=258431
>
>
> Repository: ksnapshot
>
>
> Description
> -------
>
> KSnapshot cannot open unsaved files because it uses the next incremented file \
> number. Only increment the file name on a new screengrab.
> Now it is possible to edit temporary files that get removed after closing. This \
> might confuse users but it still is better than not opening the file at all. (Maybe \
> open temp file read only?)
> I would like to commit this and cherry pick to 4.10.
>
> Original patch by Jonathan Marten
>
>
> Diffs
> -----
>
> ksnapshot.cpp f5f3e40
>
> Diff: https://git.reviewboard.kde.org/r/110349/diff/
>
>
> Testing
> -------
>
> 'Open with' works. Not only for the first file but for all snapshots. Saved and \
> unsaved.
>
> Thanks,
>
> Maarten De Meyer
>
>
--===============0910357216761194221==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110349/">https://git.reviewboard.kde.org/r/110349/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">thanks, but this is not quite the right fix. i've pushed a fix to the \
frameworks branch where current devel is happening. cheers, and thanks for taking the \
time to make a patch and submit it; it's what brought the issue to my attention (i \
just took over maintainership of the app so am catching up here still :)</p></pre> \
<br />
<p>- Aaron J. Seigo</p>
<br />
<p>On May 15th, 2013, 2:20 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Graphics, Aaron J. Seigo and Richard Moore.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 2:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=258431">258431</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KSnapshot cannot open unsaved files because it uses the next incremented \
file number. Only increment the file name on a new screengrab.
Now it is possible to edit temporary files that get removed after closing. This might \
confuse users but it still is better than not opening the file at all. (Maybe open \
temp file read only?)
I would like to commit this and cherry pick to 4.10.
Original patch by Jonathan Marten</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">'Open with' works. Not only for the first file but for all \
snapshots. Saved and unsaved.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksnapshot.cpp <span style="color: grey">(f5f3e40)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110349/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0910357216761194221==--
_______________________________________________
Kde-graphics-devel mailing list
Kde-graphics-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-graphics-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic