[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    D22483: Add a Settings() for golfSolverIterationsLimit.
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2019-07-30 22:00:47
Message-ID: 8a32d0c9aa9097de550e35c3211904da () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aacid added inline comments.

INLINE COMMENTS

> golfsolver.cpp:211
>  GolfSolver::GolfSolver(const Golf *dealer)
>      : Solver()
>  {

i'd be happied if default_max_solutions was initialized here to *something*

Doesn't need to be the settings value, but i just want it to be clear that it's never used uninitalized

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D22483

To: shlomif, #kde_games
Cc: aacid, kde-games-devel

[Attachment #3 (text/html)]

<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D22483">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D22483#inline-128917">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">golfsolver.cpp:211</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "><span class="n">GolfSolver</span><span \
style="color: #aa2211">::</span><span class="n">GolfSolver</span><span \
class="p">(</span><span style="color: #aa4000">const</span> <span \
class="n">Golf</span> <span style="color: #aa2211">*</span><span \
class="n">dealer</span><span class="p">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">    <span style="color: #aa2211">:</span> <span \
class="n">Solver</span><span class="p">()</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "><span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">i&#039;d be happied if default_max_solutions was initialized here to \
*something*</p>

<p style="padding: 0; margin: 8px;">Doesn&#039;t need to be the settings value, but i \
just want it to be clear that it&#039;s never used \
uninitalized</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D22483">https://phabricator.kde.org/D22483</a></div></div><br \
/><div><strong>To: </strong>shlomif, KDE Games<br /><strong>Cc: </strong>aacid, \
kde-games-devel<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]