[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    D7560: Properly show/hide preview dialog
From:       Luigi Toscano <noreply () phabricator ! kde ! org>
Date:       2017-08-27 14:46:11
Message-ID: 20170827144609.119106.ED12DB9FAD83F9B3 () phabricator ! kde ! org
[Download RAW message or body]

ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  It works as expected. Technically the issue is not a regression, I've just noticed \
also in the kdelibs4 version. It *may* be fixed there, but up to you.  It was not \
reported as bug (btw, would you like to go through the bug list for palapeli to see \
if it's possible to close something?)

REPOSITORY
  R423 Palapeli

BRANCH
  preview

REVISION DETAIL
  https://phabricator.kde.org/D7560

To: chehrlic, #kde_games, ltoscano
Cc: ltoscano, #kde_games


[Attachment #3 (unknown)]

<table><tr><td style="">ltoscano accepted this revision.<br />ltoscano added a \
comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7560" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>It works as \
expected. Technically the issue is not a regression, I&#039;ve just noticed also in \
the kdelibs4 version. It *may* be fixed there, but up to you.<br /> It was not \
reported as bug (btw, would you like to go through the bug list for palapeli to see \
if it&#039;s possible to close something?)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R423 Palapeli</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>preview</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7560" \
rel="noreferrer">https://phabricator.kde.org/D7560</a></div></div><br \
/><div><strong>To: </strong>chehrlic, KDE Games, ltoscano<br /><strong>Cc: \
</strong>ltoscano, KDE Games<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]