[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    D7560: Properly show/hide preview dialog
From:       Christian Ehrlicher <noreply () phabricator ! kde ! org>
Date:       2017-08-26 15:47:05
Message-ID: differential-rev-PHID-DREV-luboxiubluh5f5iuxcn3-req () phabricator ! kde ! org
[Download RAW message or body]

chehrlic created this revision.
Restricted Application added a reviewer: KDE Games.
Restricted Application added a subscriber: KDE Games.

REVISION SUMMARY
  The visiblity of the preview dialog was not synced with the preview action
  
    in the main window. Also the preview image was not created when then same
    puzzle was opened after going back to the overview.
    Some c++11 changed (using nullptr instead 0)
    don't leak PuzzleComponent in GamePlay::loadPreview()

TEST PLAN
  - make sure to have a clean environment (e.g. no saved puzzles)
    - open a puzzle, activate preview
    - go back to overview
    - open another puzzle -> no preview and button state is unchecked
    - go back to overview
    - open first puzzle -> preview is open and button state is checked
    - go back to overview
    - open puzzle again -> preview does show something (instead 'Image is not available')

REPOSITORY
  R423 Palapeli

BRANCH
  preview

REVISION DETAIL
  https://phabricator.kde.org/D7560

AFFECTED FILES
  src/engine/gameplay.cpp
  src/window/mainwindow.cpp

To: chehrlic, #kde_games
Cc: #kde_games

[Attachment #3 (unknown)]

<table><tr><td style="">chehrlic created this revision.<br />Restricted Application \
added a reviewer: KDE Games.<br />Restricted Application added a subscriber: KDE \
Games. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7560" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The \
visiblity of the preview dialog was not synced with the preview action</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">in the main window. Also the \
preview image was not created when then same puzzle was opened after going back to \
the overview. Some c++11 changed (using nullptr instead 0)
don&#039;t leak PuzzleComponent in GamePlay::loadPreview()</pre></div></div></div><br \
/><div><strong>TEST PLAN</strong><div><ul class="remarkup-list"> <li \
class="remarkup-list-item">make sure to have a clean environment (e.g. no saved \
puzzles)<ul class="remarkup-list"> <li class="remarkup-list-item">open a puzzle, \
activate preview</li> <li class="remarkup-list-item">go back to overview</li>
<li class="remarkup-list-item">open another puzzle -&gt; no preview and button state \
is unchecked</li> <li class="remarkup-list-item">go back to overview</li>
<li class="remarkup-list-item">open first puzzle -&gt; preview is open and button \
state is checked</li> <li class="remarkup-list-item">go back to overview</li>
<li class="remarkup-list-item">open puzzle again -&gt; preview does show something \
(instead &#039;Image is not available&#039;)</li> </ul></li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R423 \
Palapeli</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>preview</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7560" \
rel="noreferrer">https://phabricator.kde.org/D7560</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/engine/gameplay.cpp<br /> \
src/window/mainwindow.cpp</div></div></div><br /><div><strong>To: </strong>chehrlic, \
KDE Games<br /><strong>Cc: </strong>KDE Games<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]