[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: Palapeli/frameworks: reviews and a bug
From:       Ian Wadham <iandw.au () gmail ! com>
Date:       2017-08-24 0:07:40
Message-ID: 8F2168F6-6145-4E3F-B9BC-79951B9A8D3E () gmail ! com
[Download RAW message or body]


On 24/08/2017, at 9:22 AM, Luigi Toscano wrote:

> Hi Christian,
> 
> I added a comment to the the last "port away from KDELibs4Support" review, but
> if that it's solved, I will approve the patch.
> 
> That said, I see a bug (or more bugs, but most likely connected) related to
> the status of the game.
> If you start playing and then switch to another puzzle, the other puzzle will
> be partially solved, more or less with the same amount of pieces solved in the
> first one (or the same proportion of pieces compared to the total).
> If you complete a puzzle, even if the games asks to restart it, it is never
> restarted and the games continues to ask if you want to restar it.; if you
> switch to other puzzles, they are complete as well.
> 
> Do you see these as well? Could you please take a look?

Is Palapeli correctly removing and re-creating its save-file in engine/gameplay.cpp,
procedures Palapeli::GamePlay::restartPuzzle() and Palapeli::GamePlay::loadPuzzle()?
Ditto with loading a different save-file when you switch puzzles?

Cheers, Ian W.


[prev in list] [next in list] [prev in thread] [next in thread]