[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    D7044: Finish removing dependance to KDElibs4Support
From:       Nemanja_Hiršl <noreply () phabricator ! kde ! org>
Date:       2017-08-01 21:17:58
Message-ID: 20170801211756.5483.2260F0B7292C9D4D () phabricator ! kde ! org
[Download RAW message or body]

nhirsl added a comment.


  At this point, my first attempt to remove kdelibs4support was almost the same. \
However, I haven't submitted the change. There are two main reasons for this:  
  1. I haven't tested xmpp part of the game, even everything else worked good
  2. Irislib and jabber part are outdated and there are newer versions available
  
  To cover first item I was going to start new email thread (still saved in the \
draft), but since we have the review, I'll discuss it here.  
  **Testing xmpp part** 
  Is there anything special needed for setting up xmpp game?
  For this purpose I asked our sysadmins and promptly got two accounts on kdetalk \
(thanks to Ben!):  
  1. ksirk-dev1@kdetalk.net - password 'f59ArDehbEjgvhit'
  2. ksirk-dev2@kdetalk.net - password 'C9cbf3iMxSR8jqKn'
  
  However I couldn't setup a game. Unfortunately, didn't have time to dive deeper and \
find root cause.  
  **New iris and jabber library**  
  In the meantime, I pulled latest iris lib and with a few minor changes mostly in \
cmake files I compiled it and integrated into ksirk. Changes in Jabber part (from \
Kopete) and the rest of ksirk were also aligned and minimal. Cutestuff also changed \
location within the iris lib which makes diff almost unusable.  I do have all these \
changes in the local branch, but not tested. In this case I can verify that \
connecting to kdetalk.net succeeds, but the first next thing - getting roster list \
fails. Again (unfortunately), not sure when I can continue investigation in this \
direction.  
  Now the question is how to proceed?
  Gael, have you tested xmpp part of the game?
  
  If changes in this review work, I would vote for pushing them and than later \
upgrading iris and jabber (if at all). But I'm not sure what's the best option if we \
can't verify that iris and jabber changes are OK.

REPOSITORY
  R413 KsirK

REVISION DETAIL
  https://phabricator.kde.org/D7044

To: kleag, #kde_games, nhirsl, mlaurent
Cc: #kde_games


[Attachment #3 (unknown)]

<table><tr><td style="">nhirsl added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7044" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>At this point, my first attempt to remove \
kdelibs4support was almost the same. However, I haven&#039;t submitted the change. \
There are two main reasons for this:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">I haven&#039;t tested xmpp part of the game, even \
everything else worked good</li> <li class="remarkup-list-item">Irislib and jabber \
part are outdated and there are newer versions available</li> </ol>

<p>To cover first item I was going to start new email thread (still saved in the \
draft), but since we have the review, I&#039;ll discuss it here.</p>

<p><strong>Testing xmpp part</strong> <br />
Is there anything special needed for setting up xmpp game?<br />
For this purpose I asked our sysadmins and promptly got two accounts on kdetalk \
(thanks to Ben!):</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">ksirk-dev1@kdetalk.net - password \
&#039;f59ArDehbEjgvhit&#039;</li> <li \
class="remarkup-list-item">ksirk-dev2@kdetalk.net - password \
&#039;C9cbf3iMxSR8jqKn&#039;</li> </ol>

<p>However I couldn&#039;t setup a game. Unfortunately, didn&#039;t have time to dive \
deeper and find root cause.</p>

<p><strong>New iris and jabber library</strong>  <br />
In the meantime, I pulled latest iris lib and with a few minor changes mostly in \
cmake files I compiled it and integrated into ksirk. Changes in Jabber part (from \
Kopete) and the rest of ksirk were also aligned and minimal. Cutestuff also changed \
location within the iris lib which makes diff almost unusable.<br /> I do have all \
these changes in the local branch, but not tested. In this case I can verify that \
connecting to kdetalk.net succeeds, but the first next thing - getting roster list \
fails. Again (unfortunately), not sure when I can continue investigation in this \
direction.</p>

<p>Now the question is how to proceed?<br />
Gael, have you tested xmpp part of the game?</p>

<p>If changes in this review work, I would vote for pushing them and than later \
upgrading iris and jabber (if at all). But I&#039;m not sure what&#039;s the best \
option if we can&#039;t verify that iris and jabber changes are \
OK.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R413 \
KsirK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7044" \
rel="noreferrer">https://phabricator.kde.org/D7044</a></div></div><br \
/><div><strong>To: </strong>kleag, KDE Games, nhirsl, mlaurent<br /><strong>Cc: \
</strong>KDE Games<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]