[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: Review Request 129015: Fix "switchBall" logic when no balls available to use in repository
From:       Burkhard_Lück <lueck () hube-lueck ! de>
Date:       2017-07-27 12:15:32
Message-ID: 20170727121532.30502.20292 () mimi ! kde ! org
[Download RAW message or body]

--===============1970878972157089195==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129015/#review103481
-----------------------------------------------------------



applied the patch and I can add no more balls then defined by the difficulty level
without the patch I can add countless number of balls, regardless of the number of \
balls defined

+1 from my check

- Burkhard Lück


On Juli 24, 2017, 1:22 nachm., Stefan Yohansson Areeira Pinto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129015/
> -----------------------------------------------------------
> 
> (Updated Juli 24, 2017, 1:22 nachm.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kblackbox
> 
> 
> Description
> -------
> 
> If you have only two balls in repository (very easy mode),
> you can place more then two balls on blackbox.
> 
> 
> Diffs
> -----
> 
> kbbscalablegraphicwidget.cpp b9ca8f7 
> 
> Diff: https://git.reviewboard.kde.org/r/129015/diff/
> 
> 
> Testing
> -------
> 
> bug:
> https://vimeo.com/184207730
> 
> bugfix:
> https://vimeo.com/184207731
> 
> 
> Thanks,
> 
> Stefan Yohansson Areeira Pinto
> 
> 


--===============1970878972157089195==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129015/">https://git.reviewboard.kde.org/r/129015/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">applied the patch and I can add no more balls then defined by the \
difficulty level without the patch I can add countless number of balls, regardless of \
the number of balls defined</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">+1 from my check</p></pre>  <br />









<p>- Burkhard Lück</p>


<br />
<p>On Juli 24th, 2017, 1:22 nachm. UTC, Stefan Yohansson Areeira Pinto wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Stefan Yohansson Areeira Pinto.</div>


<p style="color: grey;"><i>Updated Juli 24, 2017, 1:22 nachm.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kblackbox
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If you have only two balls in repository (very easy \
mode), you can place more then two balls on blackbox.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">bug: https://vimeo.com/184207730</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">bugfix: https://vimeo.com/184207731</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kbbscalablegraphicwidget.cpp <span style="color: grey">(b9ca8f7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129015/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============1970878972157089195==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic