[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: Review Request 130071: [kajongg] Add missing KF5I18n dependency
From: Wolfgang Rohdewald <wolfgang () rohdewald ! de>
Date: 2017-04-08 21:50:12
Message-ID: 20170408215012.4570.89852 () mimi ! kde ! org
[Download RAW message or body]
--===============3125911910462102001==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On April 8, 2017, 9:40 nachm., Luigi Toscano wrote:
> > Kajongg is a bit complicated, as it has an alternative implementation of KI18n. \
> > Now that the bindings for Frameworks are available, maybe this can change, but \
> > right now maybe we could add an exception in the tarball generation scripts (like \
> > for ktp-desktop-applets).
I have never seen an announcement that bindings for Frameworks are available, \
certainly not on the kde-bindings mailing list. To me, it seems still in develepment. \
Where did you read that?
- Wolfgang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130071/#review103014
-----------------------------------------------------------
On April 8, 2017, 9:49 nachm., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130071/
> -----------------------------------------------------------
>
> (Updated April 8, 2017, 9:49 nachm.)
>
>
> Review request for KDE Games, Luigi Toscano and Wolfgang Rohdewald.
>
>
> Repository: kajongg
>
>
> Description
> -------
>
> Release tarball expects it for ki18n_install.
>
>
> Diffs
> -----
>
> CMakeLists.txt c25a94ff28a4e61e2591b6214ecc84325d71b7bf
>
> Diff: https://git.reviewboard.kde.org/r/130071/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============3125911910462102001==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130071/">https://git.reviewboard.kde.org/r/130071/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 8th, 2017, 9:40 nachm. UTC, <b>Luigi \
Toscano</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Kajongg is a bit complicated, as it has an alternative \
implementation of KI18n. Now that the bindings for Frameworks are available, maybe \
this can change, but right now maybe we could add an exception in the tarball \
generation scripts (like for ktp-desktop-applets).</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
have never seen an announcement that bindings for Frameworks are available, certainly \
not on the kde-bindings mailing list. To me, it seems still in develepment. Where did \
you read that?</p></pre> <br />
<p>- Wolfgang</p>
<br />
<p>On April 8th, 2017, 9:49 nachm. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games, Luigi Toscano and Wolfgang Rohdewald.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated April 8, 2017, 9:49 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kajongg
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Release tarball expects it for \
ki18n_install.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(c25a94ff28a4e61e2591b6214ecc84325d71b7bf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130071/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3125911910462102001==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic