[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 127568: [palapeli] Fix dependencies, search for KF5DocTools
From: Ian Wadham <iandw.au () gmail ! com>
Date: 2016-04-09 3:46:55
Message-ID: 20160409034655.3519.48684 () mimi ! kde ! org
[Download RAW message or body]
--===============7440568143080258865==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On April 5, 2016, 9:33 p.m., Ian Wadham wrote:
> > Re crashing at startup - possibly this is because of failure to load Palapeli's \
> > plugins.
> > If you have an empty user's data directory, the first thing Palapeli does is to \
> > retrieve the image-files for the sample jigsaw-puzzles (Castle of Maintenon, \
> > etc.), then slice them into pieces, shuffle them and store them in the user's \
> > data-directory, then finally bring up the item-list of sample puzzles on the \
> > screen. So a lot of Palapeli code gets exercised the first time a user loads the \
> > game.
> > Slicing requires loading a plugin library (called libpala IIRC). Loading plugins \
> > requires kdeinit and friends to be running --- in the file-environment in which \
> > you are testing, which is not necessarily the same as the desktop's normal \
> > file-environment. One of them (I forget which) loads the plugins.
> > You can easily check if this is what is going wrong by looking at the stderr log \
> > of Palapeli. There should be some message about failing to find or load plugins.
>
> Ian Wadham wrote:
> I seem to remember that (with Apple OS X and KDE 4) I needed to run kbuildsycoca \
> after builng and installing, in my testing environment - to get the plugins to \
> load. So try kbuildsycoca(5?).
> Andreas Sturmlechner wrote:
> My testing environment is actually my regular Gentoo environment, package manager \
> pulls from git in that case, so that shouldn't be the problem. Anyway, \
> kbuildsycoca5 didn't change anything unfortunately. On startup, a collection \
> directory is created but remains empty while palapeli segfaults:
> [KCrash Handler]
> #6 Palapeli::Puzzle::get (this=0x0, \
> type=type@entry=Palapeli::PuzzleComponent::DirectoryStorage) at \
> palapeli-5.9999/src/file-io/puzzle.cpp:119 #7 0x000000000045dc89 in \
> Palapeli::ArchiveStorageComponent::cast (this=<optimized out>, \
> type=Palapeli::PuzzleComponent::Metadata) at \
> palapeli-5.9999/src/file-io/components-archivestorage.cpp:46 #8 0x000000000043856c \
> in Palapeli::GamePlay::loadPreview (this=0x264ce50) at \
> palapeli-5.9999/src/engine/gameplay.cpp:224
> I guess that would be material for a separate bug.
I think it is a bug in the porting of Palapeli to Frameworks, which was only \
partially done FWICR, so it is not appropriate to report it on Bugzilla. In any case, \
I am the only maintainer and would not be able to tackle the problem, because I work \
on an Apple OS X machine. Qt5 and KF5/Frameworks are not yet available to me there.
If you would like to have a go at this problem, I can help with advice on how \
Palapeli startup works in KDE 4 and maybe suggest a patch sometimes, but I cannot \
test and commit any code on the frameworks branch. If you wish to go ahead with this, \
I suggest we start a thread on the KDE Games list.
FWIW, re the above crash details, I cannot for the life of me see how Palapeli could \
have reached Palapeli::GamePlay::loadPreview() during startup. That should happen \
only after the collection-view has appeared and the user has selected a puzzle to \
solve. The procedure fetches an image of how the finished jigsaw puzzle should look.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127568/#review94318
-----------------------------------------------------------
On April 3, 2016, 10:32 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127568/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 10:32 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: palapeli
>
>
> Description
> -------
>
> Fix dependencies, search for KF5DocTools
>
>
> Diffs
> -----
>
> CMakeLists.txt 6a867bf9a4f58e5a760c749c71f9c2011306115e
>
> Diff: https://git.reviewboard.kde.org/r/127568/diff/
>
>
> Testing
> -------
>
> Build is fine, runtime not (crashes at startup before and after commit)
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============7440568143080258865==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127568/">https://git.reviewboard.kde.org/r/127568/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 5th, 2016, 9:33 p.m. UTC, <b>Ian \
Wadham</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Re crashing at startup - possibly this is because of \
failure to load Palapeli's plugins.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">If you have an empty \
user's data directory, the first thing Palapeli does is to retrieve the image-files \
for the sample jigsaw-puzzles (Castle of Maintenon, etc.), then slice them into \
pieces, shuffle them and store them in the user's data-directory, then finally bring \
up the item-list of sample puzzles on the screen. So a lot of Palapeli code gets \
exercised the first time a user loads the game.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Slicing requires loading a plugin library (called libpala IIRC). Loading \
plugins requires kdeinit and friends to be running --- in the file-environment in \
which you are testing, which is not necessarily the same as the desktop's normal \
file-environment. One of them (I forget which) loads the plugins.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">You can easily check if this is what is going wrong by looking at the \
stderr log of Palapeli. There should be some message about failing to find or load \
plugins.</p></pre> </blockquote>
<p>On April 6th, 2016, 12:21 a.m. UTC, <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
seem to remember that (with Apple OS X and KDE 4) I needed to run kbuildsycoca after \
builng and installing, in my testing environment - to get the plugins to load. So try \
kbuildsycoca(5?).</p></pre> </blockquote>
<p>On April 6th, 2016, 6:05 p.m. UTC, <b>Andreas Sturmlechner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My \
testing environment is actually my regular Gentoo environment, package manager pulls \
from git in that case, so that shouldn't be the problem. Anyway, kbuildsycoca5 didn't \
change anything unfortunately. On startup, a collection directory is created but \
remains empty while palapeli segfaults:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">[KCrash Handler]</p> \
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">6 Palapeli::Puzzle::get (this=0x0, \
type=type@entry=Palapeli::PuzzleComponent::DirectoryStorage) at \
palapeli-5.9999/src/file-io/puzzle.cpp:119</h1> <h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">7 0x000000000045dc89 in Palapeli::ArchiveStorageComponent::cast \
(this=<optimized out>, type=Palapeli::PuzzleComponent::Metadata) at \
palapeli-5.9999/src/file-io/components-archivestorage.cpp:46</h1> <h1 \
style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">8 0x000000000043856c in Palapeli::GamePlay::loadPreview \
(this=0x264ce50) at palapeli-5.9999/src/engine/gameplay.cpp:224</h1> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I guess that would be material for a separate bug.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think it is a bug in the porting of Palapeli to Frameworks, which was only partially \
done FWICR, so it is not appropriate to report it on Bugzilla. In any case, I am the \
only maintainer and would not be able to tackle the problem, because I work on an \
Apple OS X machine. Qt5 and KF5/Frameworks are not yet available to me there.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If you would like to have a go at this problem, I can help with advice on \
how Palapeli startup works in KDE 4 and maybe suggest a patch sometimes, but I cannot \
test and commit any code on the frameworks branch. If you wish to go ahead with this, \
I suggest we start a thread on the KDE Games list.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">FWIW, \
re the above crash details, I cannot for the life of me see how Palapeli could have \
reached Palapeli::GamePlay::loadPreview() during startup. That should happen only \
after the collection-view has appeared and the user has selected a puzzle to solve. \
The procedure fetches an image of how the finished jigsaw puzzle should \
look.</p></pre> <br />
<p>- Ian</p>
<br />
<p>On April 3rd, 2016, 10:32 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated April 3, 2016, 10:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
palapeli
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix dependencies, search for KF5DocTools</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build is fine, runtime not (crashes at startup before \
and after commit)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(6a867bf9a4f58e5a760c749c71f9c2011306115e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127568/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7440568143080258865==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic