[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 127399: [kjumpingcube] Remove unused deps, unbreak startup
From: Ian Wadham <iandw.au () gmail ! com>
Date: 2016-03-20 3:47:51
Message-ID: 20160320034751.30507.57049 () mimi ! kde ! org
[Download RAW message or body]
--===============2755927099913052592==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127399/#review93747
-----------------------------------------------------------
CMakeLists.txt (line 10)
<https://git.reviewboard.kde.org/r/127399/#comment63903>
Do we need Qml and Quick? KJumpingCube does not use QML (Author's note).
- Ian Wadham
On March 16, 2016, 10:35 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127399/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 10:35 p.m.)
>
>
> Review request for KDE Games, Ian Wadham and Frederik Schwarzer.
>
>
> Bugs: 357409
> http://bugs.kde.org/show_bug.cgi?id=357409
>
>
> Repository: kjumpingcube
>
>
> Description
> -------
>
> Removed unused deps. Added a second commit that unbreaks startup.
>
>
> Diffs
> -----
>
> CMakeLists.txt a53ac48b795a31855fa2518135d245563ed6c55b
> main.cpp 46a8759c8cecf9b02c7ea91ea7d093e56ea715b0
>
> Diff: https://git.reviewboard.kde.org/r/127399/diff/
>
>
> Testing
> -------
>
> Builds fine without these deps.
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============2755927099913052592==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127399/">https://git.reviewboard.kde.org/r/127399/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127399/diff/1-2/?file=453388#file453388line10" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revisions 1 - 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">10</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">find_package(Qt5 \
${QT_MIN_VERSION} REQUIRED NO_MODULE COMPONENTS Widgets Qml Quick <span \
class="hl">QuickWidgets </span>Svg)</pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">10</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">find_package(Qt5 \
${QT_MIN_VERSION} REQUIRED NO_MODULE COMPONENTS Widgets Qml Quick Svg)</pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do we \
need Qml and Quick? KJumpingCube does not use QML (Author's note).</p></pre> </div>
</div>
<br />
<p>- Ian Wadham</p>
<br />
<p>On March 16th, 2016, 10:35 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games, Ian Wadham and Frederik Schwarzer.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated March 16, 2016, 10:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=357409">357409</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjumpingcube
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Removed unused deps. Added a second commit that \
unbreaks startup.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds fine without these deps.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(a53ac48b795a31855fa2518135d245563ed6c55b)</span></li>
<li>main.cpp <span style="color: \
grey">(46a8759c8cecf9b02c7ea91ea7d093e56ea715b0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127399/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2755927099913052592==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic