[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 126860: [kigo] Initialise KCrash
From: Ian Wadham <iandw.au () gmail ! com>
Date: 2016-01-24 21:46:50
Message-ID: 20160124214650.17778.17000 () mimi ! kde ! org
[Download RAW message or body]
--===============1457331107405917219==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 24, 2016, 8:54 a.m., Frederik Schwarzer wrote:
> > I think we only need to do this in libkdegames, since none of the games runs \
> > without it.
> > Or is there a benefit in initialising it in each game separately?
>
> Andreas Sturmlechner wrote:
> I don't know if it can be done in libkdegames, the problem right now is that kigo \
> will not link KCrash on many distributions that pass --as-needed to the linker. So, \
> many applications have been patched to run initialize in main.cpp. See also: \
> http://thread.gmane.org/gmane.comp.kde.devel.frameworks/27044/
> Albert Astals Cid wrote:
> Where in libkdegames would you add it?
>
> Frederik Schwarzer wrote:
> To be honest, no idea. :D
> The apidoc of initialize() says that it is called in KF5. I thought it might be \
> good to lift it one layer of libraries up and avoid calling it in each game \
> separately.
> The discussion linked above however gives the impression that it is not yet 100 % \
> clear how KCrash is handled. For now it seems best to link against KCrash and call \
> its initialize method and thus require KF5 >5.15.
> This is a discussion for all games so if we have a consens we should put it on the \
> mailing list in the thread I started yesterday about this. :)
Is it possible to add KCrash to KStandardGameAction? If so, that could take in most \
(if not all) games.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126860/#review91509
-----------------------------------------------------------
On Jan. 23, 2016, 10:26 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126860/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 10:26 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: kigo
>
>
> Description
> -------
>
> Initialise KCrash
>
>
> Diffs
> -----
>
> CMakeLists.txt 63e98b1eabd2b2043c76a8f11641c84213fbc7bd
> src/main.cpp 462d14e3686ba6b7a1149cdef594a05db1460dc1
>
> Diff: https://git.reviewboard.kde.org/r/126860/diff/
>
>
> Testing
> -------
>
> DrKonqi now starts as expected after crash.
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============1457331107405917219==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126860/">https://git.reviewboard.kde.org/r/126860/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 24th, 2016, 8:54 a.m. UTC, <b>Frederik \
Schwarzer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think we only need to do this in libkdegames, since \
none of the games runs without it.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Or is there a benefit \
in initialising it in each game separately?</p></pre> </blockquote>
<p>On January 24th, 2016, 10:51 a.m. UTC, <b>Andreas Sturmlechner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't know if it can be done in libkdegames, the problem right now is that kigo will \
not link KCrash on many distributions that pass --as-needed to the linker. So, many \
applications have been patched to run initialize in main.cpp. See also: \
http://thread.gmane.org/gmane.comp.kde.devel.frameworks/27044/</p></pre> \
</blockquote>
<p>On January 24th, 2016, 12:57 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Where \
in libkdegames would you add it?</p></pre> </blockquote>
<p>On January 24th, 2016, 5:03 p.m. UTC, <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To be \
honest, no idea. :D The apidoc of initialize() says that it is called in KF5. I \
thought it might be good to lift it one layer of libraries up and avoid calling it in \
each game separately.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The discussion linked above however \
gives the impression that it is not yet 100 % clear how KCrash is handled. For now it \
seems best to link against KCrash and call its initialize method and thus require KF5 \
>5.15.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a discussion for all games so if we have a \
consens we should put it on the mailing list in the thread I started yesterday about \
this. :)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it \
possible to add KCrash to KStandardGameAction? If so, that could take in most (if not \
all) games.</p></pre> <br />
<p>- Ian</p>
<br />
<p>On January 23rd, 2016, 10:26 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2016, 10:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kigo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Initialise KCrash</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">DrKonqi now starts as expected after crash.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(63e98b1eabd2b2043c76a8f11641c84213fbc7bd)</span></li>
<li>src/main.cpp <span style="color: \
grey">(462d14e3686ba6b7a1149cdef594a05db1460dc1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126860/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1457331107405917219==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic