[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 126124: Port to KF5/QT5
From: "Christian Ehrlicher" <ch.ehrlicher () gmx ! de>
Date: 2015-12-21 18:11:07
Message-ID: 20151221181107.32218.45992 () mimi ! kde ! org
[Download RAW message or body]
--===============6949516699470618807==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126124/#review89842
-----------------------------------------------------------
CMakeLists.txt (line 56)
<https://git.reviewboard.kde.org/r/126124/#comment61577>
I think the double quotes are not needed here (and maybe counterproductive \
because cmake treats this as one argument)
src/board.cpp (line 711)
<https://git.reviewboard.kde.org/r/126124/#comment61576>
The dialog should be created on the heap, not the stack, see \
https://blogs.kde.org/node/3919
src/main.cpp (line 72)
<https://git.reviewboard.kde.org/r/126124/#comment61578>
krazy: use isEmpty()
- Christian Ehrlicher
On Dez. 21, 2015, 5:30 nachm., Manoharan Sundaramoorthy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126124/
> -----------------------------------------------------------
>
> (Updated Dez. 21, 2015, 5:30 nachm.)
>
>
> Review request for KDE Games, Knights and Miha Čančula.
>
>
> Repository: knights
>
>
> Description
> -------
>
> Knights: Port to KF5/QT5
>
>
> Diffs
> -----
>
> icons/48-apps-knights.png PRE-CREATION
> icons/16-apps-knights.png PRE-CREATION
> icons/32-apps-knights.png PRE-CREATION
> doc/CMakeLists.txt 5aad7c2
> CMakeLists.txt ed25a68
> icons/64-apps-knights.png PRE-CREATION
> icons/CMakeLists.txt 7affd27
> icons/hi16-app-knights.png ee4a3d9
> icons/hi32-app-knights.png 120c7b2
> icons/hi48-app-knights.png 26684f0
> icons/hi64-app-knights.png df75196
> src/CMakeLists.txt 6d77801
> src/board.h d464bd1
> src/board.cpp 775cfd8
> src/clock.h 340c885
> src/clock.cpp 1e13366
> src/clockwidget.h 5686a95
> src/clockwidget.cpp 2a4e744
> src/core/item.cpp 30fe74e
> src/core/move.h 50e32b0
> src/core/move.cpp 4f7ca0e
> src/core/piece.cpp 4564ae8
> src/core/pos.h 343a8b5
> src/core/pos.cpp 8623c27
> src/customdifficultydialog.ui f9f7b29
> src/enginesettings.h 2942ad1
> src/enginesettings.cpp 4802ce0
> src/enginesettings.ui eb59af2
> src/externalcontrol.h 40dbf55
> src/externalcontrol.cpp 1467491
> src/gamedialog.h 5518290
> src/gamedialog.cpp 2d0a124
> src/gamedialog.ui 436887d
> src/gamemanager.h fe7f883
> src/gamemanager.cpp c9d9566
> src/historywidget.h 0d9f823
> src/historywidget.cpp 9f7f3fd
> src/historywidget.ui aacc0be
> src/knights.cpp cb688a7
> src/knights.desktop 400cf57
> src/knightsdebug.h PRE-CREATION
> src/knightsview.h 40df529
> src/knightsview.cpp 5451eb9
> src/main.cpp 504fcc5
> src/offerwidget.cpp 0993ae2
> src/org.kde.knights.desktop PRE-CREATION
> src/popup.ui d4665af
> src/promotiondialog.ui 810e67d
> src/proto/chatwidget.h 4afcdf6
> src/proto/chatwidget.cpp fa209f9
> src/proto/chatwidget.ui 82ff8b7
> src/proto/computerprotocol.cpp a0b032f
> src/proto/ficsdialog.h 93d5564
> src/proto/ficsdialog.cpp d89a07c
> src/proto/ficsdialog.ui 8eea2e7
> src/proto/ficsprotocol.h 3d3e395
> src/proto/ficsprotocol.cpp 2c9b07d
> src/proto/localprotocol.cpp 711ec5c
> src/proto/protocol.cpp e489d33
> src/proto/seekgraph.h cba3b5f
> src/proto/seekgraph.cpp 3c83591
> src/proto/textprotocol.h 8216f24
> src/proto/textprotocol.cpp d6f5290
> src/proto/uciprotocol.cpp 69d7efb
> src/proto/xboardprotocol.cpp 01fb4ae
> src/rules/chessrules.cpp 3e993e4
> src/rules/rules.h 032cde4
>
> Diff: https://git.reviewboard.kde.org/r/126124/diff/
>
>
> Testing
> -------
>
> 1. Tested Playing against gnuchess
> 2. Two human players
> 3. Playing with clock
>
>
> Thanks,
>
> Manoharan Sundaramoorthy
>
>
--===============6949516699470618807==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126124/">https://git.reviewboard.kde.org/r/126124/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126124/diff/2/?file=425013#file425013line57" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">56</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">add_definitions</span><span class="p">(</span><span \
class="s2">"-DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_TO_ASCII"</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think the double quotes are not needed here (and maybe counterproductive because \
cmake treats this as one argument)</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126124/diff/2/?file=425026#file425026line721" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/board.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Board::changeDisplayedPlayer()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">711</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span> <span class="n">dialog</span><span \
class="p">.</span><span class="n">exec</span><span class="p">()</span> <span \
class="o">==</span> <span class="n">QDialog</span><span class="o">::</span><span \
class="n">Accepted</span> <span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
dialog should be created on the heap, not the stack, see \
https://blogs.kde.org/node/3919</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126124/diff/2/?file=425056#file425056line74" \
style="color: black; font-weight: bold; text-decoration: underline;">src/main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">61</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KCmdLineArgs</span> <span class="o">*</span><span class="n">args</span> \
<span class="o">=</span> <span class="n">KCmdLineArgs</span><span \
class="o">::</span><span class="n">parsedArgs</span><span \
class="p">();</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">72</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span> <span class="n">parser</span><span class="p">.</span><span \
class="n">positionalArguments</span><span class="p">().</span><span \
class="n">count</span><span class="p">()</span> <span class="o">==</span> <span \
class="mi">0</span> <span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">krazy: use isEmpty()</p></pre> </div>
</div>
<br />
<p>- Christian Ehrlicher</p>
<br />
<p>On Dezember 21st, 2015, 5:30 nachm. UTC, Manoharan Sundaramoorthy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games, Knights and Miha Čančula.</div>
<div>By Manoharan Sundaramoorthy.</div>
<p style="color: grey;"><i>Updated Dez. 21, 2015, 5:30 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knights
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Knights: Port to KF5/QT5</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Tested Playing against \
gnuchess</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Two human players</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Playing with clock</li> </ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>icons/48-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/16-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/32-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(5aad7c2)</span></li>
<li>CMakeLists.txt <span style="color: grey">(ed25a68)</span></li>
<li>icons/64-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/CMakeLists.txt <span style="color: grey">(7affd27)</span></li>
<li>icons/hi16-app-knights.png <span style="color: grey">(ee4a3d9)</span></li>
<li>icons/hi32-app-knights.png <span style="color: grey">(120c7b2)</span></li>
<li>icons/hi48-app-knights.png <span style="color: grey">(26684f0)</span></li>
<li>icons/hi64-app-knights.png <span style="color: grey">(df75196)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6d77801)</span></li>
<li>src/board.h <span style="color: grey">(d464bd1)</span></li>
<li>src/board.cpp <span style="color: grey">(775cfd8)</span></li>
<li>src/clock.h <span style="color: grey">(340c885)</span></li>
<li>src/clock.cpp <span style="color: grey">(1e13366)</span></li>
<li>src/clockwidget.h <span style="color: grey">(5686a95)</span></li>
<li>src/clockwidget.cpp <span style="color: grey">(2a4e744)</span></li>
<li>src/core/item.cpp <span style="color: grey">(30fe74e)</span></li>
<li>src/core/move.h <span style="color: grey">(50e32b0)</span></li>
<li>src/core/move.cpp <span style="color: grey">(4f7ca0e)</span></li>
<li>src/core/piece.cpp <span style="color: grey">(4564ae8)</span></li>
<li>src/core/pos.h <span style="color: grey">(343a8b5)</span></li>
<li>src/core/pos.cpp <span style="color: grey">(8623c27)</span></li>
<li>src/customdifficultydialog.ui <span style="color: grey">(f9f7b29)</span></li>
<li>src/enginesettings.h <span style="color: grey">(2942ad1)</span></li>
<li>src/enginesettings.cpp <span style="color: grey">(4802ce0)</span></li>
<li>src/enginesettings.ui <span style="color: grey">(eb59af2)</span></li>
<li>src/externalcontrol.h <span style="color: grey">(40dbf55)</span></li>
<li>src/externalcontrol.cpp <span style="color: grey">(1467491)</span></li>
<li>src/gamedialog.h <span style="color: grey">(5518290)</span></li>
<li>src/gamedialog.cpp <span style="color: grey">(2d0a124)</span></li>
<li>src/gamedialog.ui <span style="color: grey">(436887d)</span></li>
<li>src/gamemanager.h <span style="color: grey">(fe7f883)</span></li>
<li>src/gamemanager.cpp <span style="color: grey">(c9d9566)</span></li>
<li>src/historywidget.h <span style="color: grey">(0d9f823)</span></li>
<li>src/historywidget.cpp <span style="color: grey">(9f7f3fd)</span></li>
<li>src/historywidget.ui <span style="color: grey">(aacc0be)</span></li>
<li>src/knights.cpp <span style="color: grey">(cb688a7)</span></li>
<li>src/knights.desktop <span style="color: grey">(400cf57)</span></li>
<li>src/knightsdebug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knightsview.h <span style="color: grey">(40df529)</span></li>
<li>src/knightsview.cpp <span style="color: grey">(5451eb9)</span></li>
<li>src/main.cpp <span style="color: grey">(504fcc5)</span></li>
<li>src/offerwidget.cpp <span style="color: grey">(0993ae2)</span></li>
<li>src/org.kde.knights.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/popup.ui <span style="color: grey">(d4665af)</span></li>
<li>src/promotiondialog.ui <span style="color: grey">(810e67d)</span></li>
<li>src/proto/chatwidget.h <span style="color: grey">(4afcdf6)</span></li>
<li>src/proto/chatwidget.cpp <span style="color: grey">(fa209f9)</span></li>
<li>src/proto/chatwidget.ui <span style="color: grey">(82ff8b7)</span></li>
<li>src/proto/computerprotocol.cpp <span style="color: grey">(a0b032f)</span></li>
<li>src/proto/ficsdialog.h <span style="color: grey">(93d5564)</span></li>
<li>src/proto/ficsdialog.cpp <span style="color: grey">(d89a07c)</span></li>
<li>src/proto/ficsdialog.ui <span style="color: grey">(8eea2e7)</span></li>
<li>src/proto/ficsprotocol.h <span style="color: grey">(3d3e395)</span></li>
<li>src/proto/ficsprotocol.cpp <span style="color: grey">(2c9b07d)</span></li>
<li>src/proto/localprotocol.cpp <span style="color: grey">(711ec5c)</span></li>
<li>src/proto/protocol.cpp <span style="color: grey">(e489d33)</span></li>
<li>src/proto/seekgraph.h <span style="color: grey">(cba3b5f)</span></li>
<li>src/proto/seekgraph.cpp <span style="color: grey">(3c83591)</span></li>
<li>src/proto/textprotocol.h <span style="color: grey">(8216f24)</span></li>
<li>src/proto/textprotocol.cpp <span style="color: grey">(d6f5290)</span></li>
<li>src/proto/uciprotocol.cpp <span style="color: grey">(69d7efb)</span></li>
<li>src/proto/xboardprotocol.cpp <span style="color: grey">(01fb4ae)</span></li>
<li>src/rules/chessrules.cpp <span style="color: grey">(3e993e4)</span></li>
<li>src/rules/rules.h <span style="color: grey">(032cde4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126124/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6949516699470618807==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic