'Re: [Kde-games-devel] Review Request 125947: Remove unused dependencies.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request 125947: Remove unused dependencies.
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2015-11-04 21:24:47
Message-ID: 20151104212447.24343.33201 () mimi ! kde ! org
[Download RAW message or body]

--===============3882922368926407482==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125947/#review88024
-----------------------------------------------------------

Ship it!

Ship It!

- Albert Astals Cid

On nov. 4, 2015, 6:07 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125947/
> -----------------------------------------------------------
> 
> (Updated nov. 4, 2015, 6:07 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kbounce
> 
> 
> Description
> -------
> 
> I can't find any usage of these dependencies, so remove them.
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt d030c17ca60caf9cd6c38edda457e6cd6a27d92b 
> 
> Diff: https://git.reviewboard.kde.org/r/125947/diff/
> 
> 
> Testing
> -------
> 
> Inspected source, builds, runs.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
> 

--===============3882922368926407482==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125947/">https://git.reviewboard.kde.org/r/125947/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Albert Astals Cid</p>

<br />
<p>On novembre 4th, 2015, 6:07 p.m. UTC, Michael Palimaka wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Michael Palimaka.</div>

<p style="color: grey;"><i>Updated nov. 4, 2015, 6:07 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kbounce
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I can't find any usage of these dependencies, so \
remove them.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Inspected source, builds, runs.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(d030c17ca60caf9cd6c38edda457e6cd6a27d92b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125947/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3882922368926407482==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 