[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 125508: Create application directory if it doesn't exist
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2015-10-03 18:24:55
Message-ID: 20151003182455.27965.92761 () mimi ! kde ! org
[Download RAW message or body]
--===============2982550829654784557==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125508/#review86306
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On Oct. 3, 2015, 11:28 a.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125508/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 11:28 a.m.)
>
>
> Review request for KDE Games.
>
>
> Bugs: 350160
> http://bugs.kde.org/show_bug.cgi?id=350160
>
>
> Repository: kpat
>
>
> Description
> -------
>
> Unlike KStandardDirs, QStandardDirs doesn't guarantee that the returned directory \
> actually exists, see also \
> https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs .
> This patch checks for the existence of the directory and creates it if it isn't \
> there, before the game state is saved.
>
> Diffs
> -----
>
> mainwindow.cpp e604a79
>
> Diff: https://git.reviewboard.kde.org/r/125508/diff/
>
>
> Testing
> -------
>
> - Delete ~/.local/share/kpat if it exists
> - Run kpat
> - Enable "Remember State on Exit" in the Settings menu
> - Select a game and play some moves
> - Quit kpat and start it again
>
> The game is correctly restored now.
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
--===============2982550829654784557==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125508/">https://git.reviewboard.kde.org/r/125508/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Jeremy Whiting</p>
<br />
<p>On October 3rd, 2015, 11:28 a.m. MDT, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2015, 11:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=350160">350160</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpat
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Unlike KStandardDirs, QStandardDirs doesn't guarantee \
that the returned directory actually exists, see also \
https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs .</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This patch checks for the existence of the directory and creates it if it \
isn't there, before the game state is saved.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Delete \
~/.local/share/kpat if it exists</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Run kpat</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Enable "Remember State on Exit" in the Settings menu</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Select a game and play some moves</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Quit kpat and start it \
again</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The game is correctly restored now.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(e604a79)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125508/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2982550829654784557==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic