'[Kde-games-devel] Review Request 123041: [kpat] Unbreak startup via KRun (krunner/kickoff, etc)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    [Kde-games-devel] Review Request 123041: [kpat] Unbreak startup via KRun (krunner/kickoff, etc)
From:       "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date:       2015-03-18 19:35:03
Message-ID: 20150318193503.15053.38863 () mimi ! kde ! org
[Download RAW message or body]

--===============5420378303587636677==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123041/
-----------------------------------------------------------

Review request for KDE Games and Laurent Montel.

Bugs: 345014
    http://bugs.kde.org/show_bug.cgi?id=345014

Repository: kpat

Description
-------

We need to register to DBus, otherwise klauncher will block. Also removed caption \
option

Diffs
-----

  CMakeLists.txt d9a268b 
  main.cpp c1049fe 
  org.kde.kpat.desktop 51afadc 

Diff: https://git.reviewboard.kde.org/r/123041/diff/

Testing
-------

Thanks,

Hrvoje Senjan

--===============5420378303587636677==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123041/">https://git.reviewboard.kde.org/r/123041/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Games and Laurent Montel.</div>
<div>By Hrvoje Senjan.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=345014">345014</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kpat
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We need to register to DBus, otherwise klauncher will \
block. Also removed caption option</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(d9a268b)</span></li>

 <li>main.cpp <span style="color: grey">(c1049fe)</span></li>

 <li>org.kde.kpat.desktop <span style="color: grey">(51afadc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123041/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5420378303587636677==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 