'Re: [Kde-games-devel] Review Request 122963: [ksirk frameworks] Replace KDialog with QDialog.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request 122963: [ksirk frameworks] Replace KDialog with QDialog.
From:       "Laurent Montel" <montel () kde ! org>
Date:       2015-03-15 14:51:24
Message-ID: 20150315145124.20027.7960 () mimi ! kde ! org
[Download RAW message or body]

--===============2084467645861642941==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122963/#review77530
-----------------------------------------------------------

Ship it!

Seems good for me.
Ship it

- Laurent Montel

On mars 15, 2015, 2:28 après-midi, Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122963/
> -----------------------------------------------------------
> 
> (Updated mars 15, 2015, 2:28 après-midi)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksirk
> 
> 
> Description
> -------
> 
> Using QDialog instead deprecated KDialog in frameworks branch
> 
> 
> Diffs
> -----
> 
> ksirk/Dialogs/InvasionSlider.h 11646e3 
> ksirk/Dialogs/InvasionSlider.cpp f15dfbd 
> ksirk/kgamewin.h 61af3ee 
> ksirk/kgamewin.cpp a86d344 
> ksirkskineditor/mainwindow.h 22f1b5c 
> ksirkskineditor/mainwindow.cpp 65c199e 
> 
> Diff: https://git.reviewboard.kde.org/r/122963/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
> 

--===============2084467645861642941==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122963/">https://git.reviewboard.kde.org/r/122963/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems \
good for me. Ship it</p></pre>
 <br />

<p>- Laurent Montel</p>

<br />
<p>On mars 15th, 2015, 2:28 après-midi UTC, Nemanja Hirsl wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Nemanja Hirsl.</div>

<p style="color: grey;"><i>Updated mars 15, 2015, 2:28 après-midi</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ksirk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Using QDialog instead deprecated KDialog in frameworks \
branch</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksirk/Dialogs/InvasionSlider.h <span style="color: grey">(11646e3)</span></li>

 <li>ksirk/Dialogs/InvasionSlider.cpp <span style="color: grey">(f15dfbd)</span></li>

 <li>ksirk/kgamewin.h <span style="color: grey">(61af3ee)</span></li>

 <li>ksirk/kgamewin.cpp <span style="color: grey">(a86d344)</span></li>

 <li>ksirkskineditor/mainwindow.h <span style="color: grey">(22f1b5c)</span></li>

 <li>ksirkskineditor/mainwindow.cpp <span style="color: grey">(65c199e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122963/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2084467645861642941==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 