'Re: [Kde-games-devel] Review Request 122582: [knetwalk] Make tests optional'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request 122582: [knetwalk] Make tests optional
From:       "Laurent Montel" <montel () kde ! org>
Date:       2015-02-18 8:30:11
Message-ID: 20150218083011.4989.20207 () probe ! kde ! org
[Download RAW message or body]

--===============8960316354865000209==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122582/#review76218
-----------------------------------------------------------

Ship it!

Seems good for me.
Ship it

- Laurent Montel

On fév. 15, 2015, 9:54 après-midi, Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122582/
> -----------------------------------------------------------
> 
> (Updated fév. 15, 2015, 9:54 après-midi)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: knetwalk
> 
> 
> Description
> -------
> 
> [knetwalk] Make tests optional
> 
> Qt5Test dependency should not be mandatory, this patch makes it optional following \
> the example set by kwin. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 49f86d6df721d56d372cdb4947f48d6cde1ee54f 
> 
> Diff: https://git.reviewboard.kde.org/r/122582/diff/
> 
> 
> Testing
> -------
> 
> Built with and without tests. Currently tests fail though, before and after patch.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
> 

--===============8960316354865000209==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122582/">https://git.reviewboard.kde.org/r/122582/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems \
good for me. Ship it</p></pre>
 <br />

<p>- Laurent Montel</p>

<br />
<p>On février 15th, 2015, 9:54 après-midi UTC, Andreas Sturmlechner wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Andreas Sturmlechner.</div>

<p style="color: grey;"><i>Updated fév. 15, 2015, 9:54 après-midi</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knetwalk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[knetwalk] Make tests optional</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Qt5Test dependency should not be mandatory, this patch makes it optional \
following the example set by kwin.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built with and without tests. Currently tests fail \
though, before and after patch.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(49f86d6df721d56d372cdb4947f48d6cde1ee54f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122582/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8960316354865000209==--

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 