[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 120192: FIx for issue 337826 where the status bar would not upd
From: Stephen Michalski <stephen.c.michalski () gmail ! com>
Date: 2014-12-17 0:55:53
Message-ID: 5490D499.1040100 () gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
For some reason I'm running to build issues that I wasn't running into
before. I've had to reformat the machine the original code was on and
ended up having to reconfigure Qt4. I can try to reproduce the issue
you're experiencing once I figure out why the themes are copying to the
project output directory.
Would there be any ideas as to why this would be? I've cloned the
location from git clone git://anongit.kde.org/ksnakeduel and the only
configuration I had to make was pointing cmake to my qmake-qt4 binary.
On 12/14/2014 01:43 PM, Albert Astals Cid wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120192/
>
>
> This still seems to not totally work for me.
>
>
> This is what i did: rm ~/.kde/share/config/ktronrc (or .kde4 if your
> settings are there) start ktron
>
>
> And the welcome screen says "KSnakeDuel (0 points) versus (0 points)"
> (i.e. the name seems to be empty)
>
>
> And if i go to settings -> Configure, Right Player is empty and left
> is "Player 2".
>
>
> Can you reproduce this?
>
>
> - Albert Astals Cid
>
>
> On octubre 14th, 2014, 3:13 p.m. UTC, Stephen Michalski wrote:
>
> Review request for KDE Games and Albert Astals Cid.
> By Stephen Michalski.
>
> /Updated oct. 14, 2014, 3:13 p.m./
>
> *Bugs: * 337826 <http://bugs.kde.org/show_bug.cgi?id=337826>
> *Repository: * ksnakeduel
>
>
> Description
>
> Fix for bug 337826
>
>
> Testing
>
> Game was run for 5 rounds in player vs. player mode and then switched
> to player vs. computer mode, which was then played for 5 rounds.
>
>
> Diffs
>
> * ktron.cpp (4082ff6)
> * ktron.kcfg (ab764b9)
>
> View Diff <https://git.reviewboard.kde.org/r/120192/diff/>
>
[Attachment #5 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
For some reason I'm running to build issues that I wasn't running
into before. I've had to reformat the machine the original code was
on and ended up having to reconfigure Qt4. I can try to reproduce
the issue you're experiencing once I figure out why the themes are
copying to the project output directory.<br>
<br>
Would there be any ideas as to why this would be? I've cloned the
location from git clone git://anongit.kde.org/ksnakeduel and the
only configuration I had to make was pointing cmake to my qmake-qt4
binary.<br>
<br>
<div class="moz-cite-prefix">On 12/14/2014 01:43 PM, Albert Astals
Cid wrote:<br>
</div>
<blockquote cite="mid:20141214184305.31947.57155@probe.kde.org"
type="cite">
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table style="border: 1px #c9c399 solid; border-radius: 6px;
-moz-border-radius: 6px; -webkit-border-radius: 6px;"
bgcolor="#f9f3c9" cellpadding="12" width="100%">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To reply,
visit: <a moz-do-not-send="true"
href="https://git.reviewboard.kde.org/r/120192/">https://git.reviewboard.kde.org/r/120192/</a>
</td>
</tr>
</tbody>
</table>
<br>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
still seems to not totally work for me.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is what i did: rm \
~/.kde/share/config/ktronrc (or .kde4 if your settings are there) start ktron</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">And the welcome screen says "KSnakeDuel (0 points) \
versus (0 points)" (i.e. the name seems to be empty)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And \
if i go to settings -> Configure, Right Player is empty and left is "Player \
2".</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can you reproduce this?</p></pre> <br>
<p>- Albert Astals Cid</p>
<br>
<p>On octubre 14th, 2014, 3:13 p.m. UTC, Stephen Michalski
wrote:</p>
<table style="border: 1px #888a85 solid; border-radius: 6px;
-moz-border-radius: 6px; -webkit-border-radius: 6px;"
bgcolor="#fefadf" cellpadding="12" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<div>Review request for KDE Games and Albert Astals Cid.</div>
<div>By Stephen Michalski.</div>
<p style="color: grey;"><i>Updated oct. 14, 2014, 3:13
p.m.</i></p>
<div style="margin-top: 1.5em;"> <b style="color:
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs:
</b> <a moz-do-not-send="true"
href="http://bugs.kde.org/show_bug.cgi?id=337826">337826</a>
</div>
<div style="margin-top: 1.5em;"> <b style="color:
#575012; font-size: 10pt;">Repository: </b>
ksnakeduel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Description </h1>
<table style="border: 1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Fix for bug 337826</p></pre> </td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Testing </h1>
<table style="border: 1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Game was run for 5 rounds in player vs. \
player mode and then switched to player vs. computer mode, which was then played for \
5 rounds. </p></pre> </td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ktron.cpp <span style="color: grey">(4082ff6)</span></li>
<li>ktron.kcfg <span style="color: grey">(ab764b9)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="https://git.reviewboard.kde.org/r/120192/diff/"
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
</blockquote>
<br>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic