[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 113899: Enable multiple ships game the style I played in paper
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2014-02-06 19:25:53
Message-ID: 20140206192553.25684.91602 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113899/
-----------------------------------------------------------
(Updated Feb. 6, 2014, 7:25 p.m.)
Status
------
This change has been discarded.
Review request for KDE Games and Roney Gomes.
Bugs: 181114 and 308214
http://bugs.kde.org/show_bug.cgi?id=181114
http://bugs.kde.org/show_bug.cgi?id=308214
Repository: knavalbattle
Description
-------
The biggest change is the ship insertion order for the human players. It starts now \
by the biggest ship. This way it is impossible to reach a board where is not possible \
to place the remaining ships (it is possible starting with the smallest ones if there \
must be an space between them). If this change is too big, then I'll try to find a \
solution to detect the "impossible to place more ships" situation and enable a fresh \
placing restart. A kWarning() and a TODO in spanish are now gone.
Diffs
-----
src/ai/ai.h 738c465
src/ai/dummyai.cpp 15544e2
src/ai/smartai.h fcf7dba
src/ai/smartai.cpp 261cf01
src/controller.h e87ba48
src/controller.cpp 23b8153
src/knavalbattle.kcfg 4d78556
src/knavalbattleui.rc bd38ad8
src/mainwindow.cpp e3f2a35
src/networkentity.cpp 9f252ca
src/playerentity.h aae134e
src/playerentity.cpp 9c32b25
src/playfield.h 6a24657
src/playfield.cpp f1d774b
src/sea.h e9e7333
src/sea.cpp 51f4f0c
Diff: https://git.reviewboard.kde.org/r/113899/diff/
Testing
-------
A lot of games with and without several ships, in local against the AI or in remote \
against myself.
Thanks,
Jaime Torres Amate
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113899/">https://git.reviewboard.kde.org/r/113899/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2014, 7:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=181114">181114</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=308214">308214</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The biggest change is the ship insertion order for the human players. It \
starts now by the biggest ship. This way it is impossible to reach a board where is \
not possible to place the remaining ships (it is possible starting with the smallest \
ones if there must be an space between them). If this change is too big, then \
I'll try to find a solution to detect the "impossible to place more \
ships" situation and enable a fresh placing restart. A kWarning() and a TODO in \
spanish are now gone.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A lot of games with and without several ships, in local against the AI \
or in remote against myself.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ai/ai.h <span style="color: grey">(738c465)</span></li>
<li>src/ai/dummyai.cpp <span style="color: grey">(15544e2)</span></li>
<li>src/ai/smartai.h <span style="color: grey">(fcf7dba)</span></li>
<li>src/ai/smartai.cpp <span style="color: grey">(261cf01)</span></li>
<li>src/controller.h <span style="color: grey">(e87ba48)</span></li>
<li>src/controller.cpp <span style="color: grey">(23b8153)</span></li>
<li>src/knavalbattle.kcfg <span style="color: grey">(4d78556)</span></li>
<li>src/knavalbattleui.rc <span style="color: grey">(bd38ad8)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(e3f2a35)</span></li>
<li>src/networkentity.cpp <span style="color: grey">(9f252ca)</span></li>
<li>src/playerentity.h <span style="color: grey">(aae134e)</span></li>
<li>src/playerentity.cpp <span style="color: grey">(9c32b25)</span></li>
<li>src/playfield.h <span style="color: grey">(6a24657)</span></li>
<li>src/playfield.cpp <span style="color: grey">(f1d774b)</span></li>
<li>src/sea.h <span style="color: grey">(e9e7333)</span></li>
<li>src/sea.cpp <span style="color: grey">(51f4f0c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113899/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic