'Re: [Kde-games-devel] Review Request 114845: [knavalbattle] utilties for the several ships patch'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request 114845: [knavalbattle] utilties for the several ships patch
From:       "Jaime Torres Amate" <jtamate () gmail ! com>
Date:       2014-01-16 12:23:24
Message-ID: 20140116122324.14108.27389 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114845/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 12:23 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Games and Roney Gomes.

Repository: knavalbattle

Description
-------

These are the tools I use to check if a ship can be placed in the board or if the user/AI \
should start again. Also, it serves me to split a big patch into smaller pieces.
How it is done:
* Pass the parameter allow adjacent ships also to the BattleField.
* Implement a bool canAddShipOfSize(size). When a ship of size size can not be placed, then the \
                AI or the player should start again (what I'm working on) or an Undo.
* Implement a clear() to be able to start again
* In the battleField also add another hidden board with the cells having only two status (free, \
busy) to be able to know the availability of the cells. It is easier for me in this way than \
the other way (sending a signal to clear the ship borders when the shooting starts).

Diffs
-----

  src/battlefield.h b2f30bc 
  src/battlefield.cpp 6467d8c 
  src/sea.h 4af50b7 
  src/sea.cpp 38ab8b5 

Diff: https://git.reviewboard.kde.org/r/114845/diff/

Testing
-------

It detects the blocked boards (played much more games than I wanted to implement the restart \
placing ships).

Thanks,

Jaime Torres Amate

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114845/">https://git.reviewboard.kde.org/r/114845/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated Jan. 16, 2014, 12:23 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These are the tools I \
use to check if a ship can be placed in the board or if the user/AI should start again. Also, \
it serves me to split a big patch into smaller pieces. How it is done:
* Pass the parameter allow adjacent ships also to the BattleField.
* Implement a bool canAddShipOfSize(size). When a ship of size size can not be placed, then the \
                AI or the player should start again (what I&#39;m working on) or an Undo.
* Implement a clear() to be able to start again
* In the battleField also add another hidden board with the cells having only two status (free, \
busy) to be able to know the availability of the cells. It is easier for me in this way than \
the other way (sending a signal to clear the ship borders when the shooting starts).

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It detects the \
blocked boards (played much more games than I wanted to implement the restart placing \
ships).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/battlefield.h <span style="color: grey">(b2f30bc)</span></li>

 <li>src/battlefield.cpp <span style="color: grey">(6467d8c)</span></li>

 <li>src/sea.h <span style="color: grey">(4af50b7)</span></li>

 <li>src/sea.cpp <span style="color: grey">(38ab8b5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114845/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 