[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 114620: [knavalbattle] Show not shunk ships when the game finis
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-12-29 0:26:39
Message-ID: 20131229002639.10653.64041 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114620/#review46340
-----------------------------------------------------------
src/grid.h
<https://git.reviewboard.kde.org/r/114620/#comment33062>
can this happen?
- Albert Astals Cid
On Dec. 28, 2013, 10:03 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114620/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2013, 10:03 p.m.)
>
>
> Review request for KDE Games and Roney Gomes.
>
>
> Bugs: 168657
> http://bugs.kde.org/show_bug.cgi?id=168657
>
>
> Repository: knavalbattle
>
>
> Description
> -------
>
> This patch includes the work done by Roney in the show-ships branch (my work is only the two \
> phase end of game and the network part).
> How does it accomplishes its purpose?
> * The end game has now two phases, first send/receive the ships in the GameOverMessage, then \
> the end game part.
> * All the entities include a reference to the SeaView to be able to show the ships (included \
> in the parent class Entity)
> * The shoots are drawn over the ships
> * Instead of a parameter, the flag of adjacent ships is now a member (grabbed from the \
> multiple ships patch, to be released soon).
> * The ships have now the coordinates where they are.
> * The GameOverMessage was already ready to send/receive ships (with a little bug fixed).
> * Grid now has a copy constructor
> * Changed the name of a variable from a confusing name m_sea to a more clear m_seaview
> * There are now two lists of ships (for both entities to be able to interchange the ships)
>
> * It does not include configuration for this functionality, I think everybody expects this \
> behavior from this kind of game.
>
> Diffs
> -----
>
> src/entity.cpp 067e384
> src/grid.h ba1d43c
> src/networkentity.h ae97522
> src/networkentity.cpp 9f252ca
> src/playerentity.cpp 9c32b25
> src/playfield.h 6a24657
> src/playfield.cpp f1d774b
> src/protocol.cpp 152c9cd
> src/sea.h e9e7333
> src/sea.cpp 51f4f0c
> src/seaview.h df22a21
> src/seaview.cpp 92d6e4e
> src/ship.h f52fa95
> src/ship.cpp cf78535
> src/simplemenu.cpp cf5684d
> src/uientity.h fa92a90
> src/uientity.cpp bca8ac9
> src/ai/dummyai.cpp 2cae8d5
> src/ai/smartai.cpp 121d2de
> src/aientity.h d8d3ade
> src/aientity.cpp a7f9bca
> src/battlefield.h 83d8f5f
> src/battlefield.cpp 690bf93
> src/battlefieldview.h aaec342
> src/battlefieldview.cpp 233f1e4
> src/controller.h e87ba48
> src/controller.cpp 23b8153
> src/coord.h 32dd8c0
> src/entity.h 4955a81
>
> Diff: https://git.reviewboard.kde.org/r/114620/diff/
>
>
> Testing
> -------
>
> It works with the several ships patch (in every possible combination) and as it is, tested \
> several times in local and remote games.
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114620/">https://git.reviewboard.kde.org/r/114620/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114620/diff/2/?file=227591#file227591line52" \
style="color: black; font-weight: bold; text-decoration: underline;">src/grid.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th> \
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">grid</span><span \
class="o">!=</span><span class="n">this</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">can this happen?</pre> </div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On December 28th, 2013, 10:03 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 10:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=168657">168657</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch includes \
the work done by Roney in the show-ships branch (my work is only the two phase end of game and \
the network part).
How does it accomplishes its purpose?
* The end game has now two phases, first send/receive the ships in the GameOverMessage, then \
the end game part.
* All the entities include a reference to the SeaView to be able to show the ships (included in \
the parent class Entity)
* The shoots are drawn over the ships
* Instead of a parameter, the flag of adjacent ships is now a member (grabbed from the multiple \
ships patch, to be released soon).
* The ships have now the coordinates where they are.
* The GameOverMessage was already ready to send/receive ships (with a little bug fixed).
* Grid now has a copy constructor
* Changed the name of a variable from a confusing name m_sea to a more clear m_seaview
* There are now two lists of ships (for both entities to be able to interchange the ships)
* It does not include configuration for this functionality, I think everybody expects this \
behavior from this kind of game. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works with the \
several ships patch (in every possible combination) and as it is, tested several times in local \
and remote games.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/entity.cpp <span style="color: grey">(067e384)</span></li>
<li>src/grid.h <span style="color: grey">(ba1d43c)</span></li>
<li>src/networkentity.h <span style="color: grey">(ae97522)</span></li>
<li>src/networkentity.cpp <span style="color: grey">(9f252ca)</span></li>
<li>src/playerentity.cpp <span style="color: grey">(9c32b25)</span></li>
<li>src/playfield.h <span style="color: grey">(6a24657)</span></li>
<li>src/playfield.cpp <span style="color: grey">(f1d774b)</span></li>
<li>src/protocol.cpp <span style="color: grey">(152c9cd)</span></li>
<li>src/sea.h <span style="color: grey">(e9e7333)</span></li>
<li>src/sea.cpp <span style="color: grey">(51f4f0c)</span></li>
<li>src/seaview.h <span style="color: grey">(df22a21)</span></li>
<li>src/seaview.cpp <span style="color: grey">(92d6e4e)</span></li>
<li>src/ship.h <span style="color: grey">(f52fa95)</span></li>
<li>src/ship.cpp <span style="color: grey">(cf78535)</span></li>
<li>src/simplemenu.cpp <span style="color: grey">(cf5684d)</span></li>
<li>src/uientity.h <span style="color: grey">(fa92a90)</span></li>
<li>src/uientity.cpp <span style="color: grey">(bca8ac9)</span></li>
<li>src/ai/dummyai.cpp <span style="color: grey">(2cae8d5)</span></li>
<li>src/ai/smartai.cpp <span style="color: grey">(121d2de)</span></li>
<li>src/aientity.h <span style="color: grey">(d8d3ade)</span></li>
<li>src/aientity.cpp <span style="color: grey">(a7f9bca)</span></li>
<li>src/battlefield.h <span style="color: grey">(83d8f5f)</span></li>
<li>src/battlefield.cpp <span style="color: grey">(690bf93)</span></li>
<li>src/battlefieldview.h <span style="color: grey">(aaec342)</span></li>
<li>src/battlefieldview.cpp <span style="color: grey">(233f1e4)</span></li>
<li>src/controller.h <span style="color: grey">(e87ba48)</span></li>
<li>src/controller.cpp <span style="color: grey">(23b8153)</span></li>
<li>src/coord.h <span style="color: grey">(32dd8c0)</span></li>
<li>src/entity.h <span style="color: grey">(4955a81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114620/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic