[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 114639: [knavalbattle] avoid semi-transparents first shots
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2013-12-28 19:54:12
Message-ID: 20131228195412.10653.85157 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 28, 2013, 6:53 p.m., Albert Astals Cid wrote:
> > src/button.cpp, line 228
> > <https://git.reviewboard.kde.org/r/114639/diff/1/?file=227050#file227050line228>
> >
> > Instead of this just remove the m_current variable, it isn't used at all :D
I've just realized that this patch by itself does not avoid the semitransparent shots.
It is something from the patch to show the not sunk ships the one that does it (I've always \
thought it was this patch, so I do not know what does fix this problem).
Applied to 4.11 does not avoid the problem. Applied to 4.12 does not avoid the problem.
Applied the "show sunk ships" to 4.12 without this patch the problem is gone. Applied both, the \
problem is also gone.
Therefore if I submit this patch, it it just for code correctness.
- Jaime Torres
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114639/#review46313
-----------------------------------------------------------
On Dec. 24, 2013, 9:18 a.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114639/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2013, 9:18 a.m.)
>
>
> Review request for KDE Games and Roney Gomes.
>
>
> Bugs: 320883
> http://bugs.kde.org/show_bug.cgi?id=320883
>
>
> Repository: knavalbattle
>
>
> Description
> -------
>
> Before, after a match against the AI, and a Restart, the first shot was always \
> semi-transparent (or gray in the sea). Initialize 3 variables, and the shots are always the \
> same (white in the sea).
>
> Diffs
> -----
>
> src/animation.cpp 951b5a6
> src/button.cpp 3ff23a5
>
> Diff: https://git.reviewboard.kde.org/r/114639/diff/
>
>
> Testing
> -------
>
> It has been tested more than a hundred times (while testing the several ships and shunk ships \
> patches)
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114639/">https://git.reviewboard.kde.org/r/114639/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 28th, 2013, 6:53 p.m. UTC, <b>Albert Astals Cid</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114639/diff/1/?file=227050#file227050line228" \
style="color: black; font-weight: bold; text-decoration: underline;">src/button.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Button::setBrightness(double value)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">228</font></th> \
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"><span class="p">,</span> <span class="n">m_current</span><span class="p">(</span><span \
class="mi">0</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Instead of this just remove the m_current \
variable, it isn't used at all :D</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've just realized that this \
patch by itself does not avoid the semitransparent shots. It is something from the patch to \
show the not sunk ships the one that does it (I've always thought it was this patch, so I \
do not know what does fix this problem).
Applied to 4.11 does not avoid the problem. Applied to 4.12 does not avoid the problem.
Applied the "show sunk ships" to 4.12 without this patch the problem is gone. Applied \
both, the problem is also gone.
Therefore if I submit this patch, it it just for code correctness.</pre>
<br />
<p>- Jaime Torres</p>
<br />
<p>On December 24th, 2013, 9:18 a.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2013, 9:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=320883">320883</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before, after a match \
against the AI, and a Restart, the first shot was always semi-transparent (or gray in the sea). \
Initialize 3 variables, and the shots are always the same (white in the sea).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It has been tested \
more than a hundred times (while testing the several ships and shunk ships patches)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/animation.cpp <span style="color: grey">(951b5a6)</span></li>
<li>src/button.cpp <span style="color: grey">(3ff23a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114639/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic