[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 113054: Finally, implement a way to not shoot at places the AI
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-10-16 21:29:07
Message-ID: 20131016212907.32359.53857 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 14, 2013, 7:37 p.m., Roney Gomes wrote:
> > Hi.
> >
> > This is just to inform you that I'm aware of your patch and will review it as \
> > soon as I have the chance. I've been extremely busy with university, my job and \
> > the ordinary tasks of a home. Will hopefully have some free this next weekend.
> > Sure you will understand, thanks.
Just a quick heads up that 4.12 Feature Freeze is in 2 weeks so it'd be cool if we \
could squeeze this in :-)
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113054/#review41756
-----------------------------------------------------------
On Oct. 2, 2013, 4:44 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113054/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2013, 4:44 p.m.)
>
>
> Review request for KDE Games and Roney Gomes.
>
>
> Bugs: 318594
> http://bugs.kde.org/show_bug.cgi?id=318594
>
>
> Repository: knavalbattle
>
>
> Description
> -------
>
> (the red spaces are already gone)
> Move the addBorder to the AI entity. When notify is called after a shoot, and an \
> opponent ship is sunk, mark the surrounding cells as border, therefore, the AI will \
> not try them in the future. Added a getter for the adjacent ships property.
>
>
> Diffs
> -----
>
> src/ai/smartai.cpp 37021a8
> src/aientity.cpp c8fa775
> src/playerentity.cpp 8c7bf16
> src/sea.h c68f348
>
> Diff: http://git.reviewboard.kde.org/r/113054/diff/
>
>
> Testing
> -------
>
> played a lot against the AI, it does not use the cells around a sunk ship.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113054/">http://git.reviewboard.kde.org/r/113054/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 14th, 2013, 7:37 p.m. UTC, <b>Roney \
Gomes</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi.
This is just to inform you that I'm aware of your patch and will review it as \
soon as I have the chance. I've been extremely busy with university, my job and \
the ordinary tasks of a home. Will hopefully have some free this next weekend.
Sure you will understand, thanks.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just a quick heads up \
that 4.12 Feature Freeze is in 2 weeks so it'd be cool if we could squeeze this \
in :-)</pre> <br />
<p>- Albert</p>
<br />
<p>On October 2nd, 2013, 4:44 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Oct. 2, 2013, 4:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318594">318594</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">(the red spaces are already gone) Move the addBorder to the AI entity. \
When notify is called after a shoot, and an opponent ship is sunk, mark the \
surrounding cells as border, therefore, the AI will not try them in the future. Added \
a getter for the adjacent ships property.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">played a lot against the AI, it does not use the cells around a sunk \
ship. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ai/smartai.cpp <span style="color: grey">(37021a8)</span></li>
<li>src/aientity.cpp <span style="color: grey">(c8fa775)</span></li>
<li>src/playerentity.cpp <span style="color: grey">(8c7bf16)</span></li>
<li>src/sea.h <span style="color: grey">(c68f348)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113054/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic