'Re: [Kde-games-devel] Review Request 106772: add option to allow adjacent ships'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request 106772: add option to allow adjacent ships
From:       "Commit Hook" <null () kde ! org>
Date:       2013-03-10 9:37:55
Message-ID: 20130310093755.32530.32025 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106772/#review28865
-----------------------------------------------------------

This review has been submitted with commit 411cdc90ee801825f8b96b9d1e87b225b90f117e \
by Jaime Torres to branch master.

- Commit Hook

On March 6, 2013, 9:18 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106772/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 9:18 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Add the option to allow adjacent ships.
> When it is not checked, the ships can not be placed adjacent.
> 
> 
> This addresses bug 168659.
> http://bugs.kde.org/show_bug.cgi?id=168659
> 
> 
> Diffs
> -----
> 
> src/battlefield.h ae78166 
> src/battlefield.cpp 32aa525 
> src/controller.h bbae7a6 
> src/controller.cpp 761eda4 
> src/kbattleship.kcfg b615f30 
> src/kbattleshipui.rc 7c51ac6 
> src/mainwindow.cpp 82d9a14 
> src/message.h 2757cf7 
> src/message.cpp 59de527 
> src/networkentity.cpp 5fff5b8 
> src/playfield.h 56934dc 
> src/playfield.cpp 61c0ac6 
> src/protocol.cpp c5cbacc 
> src/sea.h e76be24 
> src/sea.cpp de8b697 
> src/ship.cpp 86858d9 
> 
> Diff: http://git.reviewboard.kde.org/r/106772/diff/
> 
> 
> Testing
> -------
> 
> tested locally.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106772/">http://git.reviewboard.kde.org/r/106772/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 411cdc90ee801825f8b96b9d1e87b225b90f117e by Jaime Torres to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 6th, 2013, 9:18 p.m. UTC, Jaime Torres Amate wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated March 6, 2013, 9:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add the option to allow adjacent ships. When it is not checked, the \
ships can not be placed adjacent.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested locally.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=168659">168659</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/battlefield.h <span style="color: grey">(ae78166)</span></li>

 <li>src/battlefield.cpp <span style="color: grey">(32aa525)</span></li>

 <li>src/controller.h <span style="color: grey">(bbae7a6)</span></li>

 <li>src/controller.cpp <span style="color: grey">(761eda4)</span></li>

 <li>src/kbattleship.kcfg <span style="color: grey">(b615f30)</span></li>

 <li>src/kbattleshipui.rc <span style="color: grey">(7c51ac6)</span></li>

 <li>src/mainwindow.cpp <span style="color: grey">(82d9a14)</span></li>

 <li>src/message.h <span style="color: grey">(2757cf7)</span></li>

 <li>src/message.cpp <span style="color: grey">(59de527)</span></li>

 <li>src/networkentity.cpp <span style="color: grey">(5fff5b8)</span></li>

 <li>src/playfield.h <span style="color: grey">(56934dc)</span></li>

 <li>src/playfield.cpp <span style="color: grey">(61c0ac6)</span></li>

 <li>src/protocol.cpp <span style="color: grey">(c5cbacc)</span></li>

 <li>src/sea.h <span style="color: grey">(e76be24)</span></li>

 <li>src/sea.cpp <span style="color: grey">(de8b697)</span></li>

 <li>src/ship.cpp <span style="color: grey">(86858d9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106772/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 