'Re: [Kde-games-devel] Review Request 108068: Ksirk Bug 309863 - just playing when crashes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request 108068: Ksirk Bug 309863 - just playing when crashes
From:       Gaël_de_Chalendar <kleag () free ! fr>
Date:       2013-02-02 11:46:21
Message-ID: 20130202114621.24161.27668 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108068/#review26539
-----------------------------------------------------------

Ship it!

Ship It!

- Gaël de Chalendar

On Jan. 13, 2013, 1:44 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108068/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 1:44 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> The crash occurs when AI is playing or Auto attack is going on and user wants to \
> see country details from context menu. Both country and fight details are shown in \
> the right dialog interfering with each other. Some safety code is added to prevent \
> new crashes. The complete solution is to disable detailed country view from the \
> context menu when AI is playing or Auto Attack is under way. This separates \
> appearing of two views at the same time in the right dialog. 
> 
> This addresses bug 309863.
> http://bugs.kde.org/show_bug.cgi?id=309863
> 
> 
> Diffs
> -----
> 
> ksirk/decoratedgameframe.cpp 7c6941e 
> ksirk/krightdialog.cpp 94fd89f 
> 
> Diff: http://git.reviewboard.kde.org/r/108068/diff/
> 
> 
> Testing
> -------
> 
> 1. While AI is playing bring up context menu (right click on the country). No more \
> "Details" entry. 2. While Auto Attack bring up context menu. No more "Details" \
> entry. 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108068/">http://git.reviewboard.kde.org/r/108068/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Gaël de</p>

<br />
<p>On January 13th, 2013, 1:44 p.m. UTC, Nemanja Hirsl wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Nemanja Hirsl.</div>

<p style="color: grey;"><i>Updated Jan. 13, 2013, 1:44 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The crash occurs when AI is playing or Auto attack is going on and user \
wants to see country details from context menu. Both country and fight details are \
shown in the right dialog interfering with each other. Some safety code is added to \
prevent new crashes. The complete solution is to disable detailed country view from \
the context menu when AI is playing or Auto Attack is under way. This separates \
appearing of two views at the same time in the right dialog.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. While AI is playing bring up context menu (right click on the \
country). No more &quot;Details&quot; entry. 2. While Auto Attack bring up context \
menu. No more &quot;Details&quot; entry.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=309863">309863</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksirk/decoratedgameframe.cpp <span style="color: grey">(7c6941e)</span></li>

 <li>ksirk/krightdialog.cpp <span style="color: grey">(94fd89f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108068/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 