[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 108068: Ksirk Bug 309863 - just playing when crashes
From: "Wolfgang Rohdewald" <wolfgang () rohdewald ! de>
Date: 2013-01-13 12:50:43
Message-ID: 20130113125043.29431.36217 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108068/#review25366
-----------------------------------------------------------
I did not try your changes (actually I never played this game), but anyway ...
ksirk/decoratedgameframe.cpp
<http://git.reviewboard.kde.org/r/108068/#comment19358>
not sure - do you fix the cause or the symptoms? It seems you are removing \
functionality from the user view. Would it be possible to make the shared resources \
shareable? If not, could you please add the reason to the comment?
ksirk/krightdialog.cpp
<http://git.reviewboard.kde.org/r/108068/#comment19359>
The fixing commit should be as small as possible, so it is easier to review.
So - if you think this should not happen anymore, why is this change needed? If \
you strongly believe so but are not 100% sure, would it be better to make this an \
assertion or at least generate warning output if it happens?
ksirk/krightdialog.cpp
<http://git.reviewboard.kde.org/r/108068/#comment19356>
trailing whitespace
- Wolfgang Rohdewald
On Jan. 1, 2013, 6:50 p.m., Nemanja Hirsl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108068/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2013, 6:50 p.m.)
>
>
> Review request for KDE Games.
>
>
> Description
> -------
>
> The crash occurs when AI is playing or Auto attack is going on and user wants to \
> see country details from context menu. Both country and fight details are shown in \
> the right dialog interfering with each other. Some safety code is added to prevent \
> new crashes. The complete solution is to disable detailed country view from the \
> context menu when AI is playing or Auto Attack is under way. This separates \
> appearing of two views at the same time in the right dialog.
>
> This addresses bug 309863.
> http://bugs.kde.org/show_bug.cgi?id=309863
>
>
> Diffs
> -----
>
> ksirk/decoratedgameframe.cpp 7c6941e
> ksirk/krightdialog.cpp 94fd89f
>
> Diff: http://git.reviewboard.kde.org/r/108068/diff/
>
>
> Testing
> -------
>
> 1. While AI is playing bring up context menu (right click on the country). No more \
> "Details" entry. 2. While Auto Attack bring up context menu. No more "Details" \
> entry.
>
> Thanks,
>
> Nemanja Hirsl
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108068/">http://git.reviewboard.kde.org/r/108068/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did not try your \
changes (actually I never played this game), but anyway ...</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108068/diff/1/?file=103622#file103622line231" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksirk/decoratedgameframe.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DecoratedGameFrame::contextMenuEvent( QContextMenuEvent * )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">231</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// Bug 309863. Details of the country and combat are both shown in the \
right widget.</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not sure - \
do you fix the cause or the symptoms? It seems you are removing functionality from \
the user view. Would it be possible to make the shared resources shareable? If not, \
could you please add the reason to the comment?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108068/diff/1/?file=103623#file103623line420" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksirk/krightdialog.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KRightDialog::updateRecycleDetails(GameLogic::Country* country, bool recyclePhase, \
int nbAvailArmies)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">420</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// Bug 309863. Should not happen anymore because Country details and Fight \
results shouldn't be mixed.</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The fixing \
commit should be as small as possible, so it is easier to review.
So - if you think this should not happen anymore, why is this change needed? If you \
strongly believe so but are not 100% sure, would it be better to make this an \
assertion or at least generate warning output if it happens?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108068/diff/1/?file=103623#file103623line424" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksirk/krightdialog.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KRightDialog::updateRecycleDetails(GameLogic::Country* country, bool recyclePhase, \
int nbAvailArmies)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">421</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">delete</span> <span class="n">movie</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">424</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span \
class="n">movie</span><span class="p">;</span><span class="ew"> </span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">trailing \
whitespace</pre> </div>
<br />
<p>- Wolfgang</p>
<br />
<p>On January 1st, 2013, 6:50 p.m. UTC, Nemanja Hirsl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Nemanja Hirsl.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2013, 6:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The crash occurs when AI is playing or Auto attack is going on and user \
wants to see country details from context menu. Both country and fight details are \
shown in the right dialog interfering with each other. Some safety code is added to \
prevent new crashes. The complete solution is to disable detailed country view from \
the context menu when AI is playing or Auto Attack is under way. This separates \
appearing of two views at the same time in the right dialog.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. While AI is playing bring up context menu (right click on the \
country). No more "Details" entry. 2. While Auto Attack bring up context \
menu. No more "Details" entry.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=309863">309863</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksirk/decoratedgameframe.cpp <span style="color: grey">(7c6941e)</span></li>
<li>ksirk/krightdialog.cpp <span style="color: grey">(94fd89f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108068/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic