From kde-games-devel Wed Jan 09 13:47:21 2013 From: "jack daniel" Date: Wed, 09 Jan 2013 13:47:21 +0000 To: kde-games-devel Subject: Re: [Kde-games-devel] Review Request: List scores according to difficulty Message-Id: <20130109134721.6512.48135 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-games-devel&m=135773926106849 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6580722899842218678==" --===============6580722899842218678== Content-Type: multipart/alternative; boundary="===============7179253186962191703==" --===============7179253186962191703== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Jan. 8, 2013, 9:42 p.m., Albert Astals Cid wrote: > > Hi Jack, the code looks good, i will need your full name and email addr= ess so we can give you proper credit when commiting the fix. Ian Simpson, ian.kdedev@yahoo.com I'll create a new account with my real name. - jack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108269/#review25010 ----------------------------------------------------------- On Jan. 8, 2013, 5:26 p.m., jack daniel wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108269/ > ----------------------------------------------------------- > = > (Updated Jan. 8, 2013, 5:26 p.m.) > = > = > Review request for KDE Games. > = > = > Description > ------- > = > Try to add scores to the correct difficulty level. > = > Someone posted a patch at bugs.kde.org, but that seems to add the score t= o the next level higher than that played. > = > KExtHighscore::setGameType() seems to add scores from level 0 up. > = > = > This addresses bug 305661. > http://bugs.kde.org/show_bug.cgi?id=3D305661 > = > = > Diffs > ----- > = > mainwindow.cpp 47d7826 = > = > Diff: http://git.reviewboard.kde.org/r/108269/diff/ > = > = > Testing > ------- > = > Lost a few games at different levels. Looks OK. > = > = > Thanks, > = > jack daniel > = > --===============7179253186962191703== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/108269/

On January 8th, 2013, 9:42 p.m., Albert Ast= als Cid wrote:

Hi Jack, =
the code looks good, i will need your full name and email address so we can=
 give you proper credit when commiting the fix.
Ian Simpson=
, ian.kdedev@yahoo.com

I'll create a new account with my real name.

- jack


On January 8th, 2013, 5:26 p.m., jack daniel wrote:

Review request for KDE Games.
By jack daniel.

Updated Jan. 8, 2013, 5:26 p.m.

Descripti= on 

Try to add scores to the correct difficulty level.

Someone posted a patch at bugs.kde.org, but that seems to add the score to =
the next level higher than that played.

KExtHighscore::setGameType() seems to add scores from level 0 up.

Testing <= /h1> 
Lost a few games at different levels. Looks OK.
Bugs: 305661

Diffs=

  • mainwindow.cpp (47d7826)

View Diff
--===============7179253186962191703==-- --===============6580722899842218678== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-games-devel mailing list kde-games-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-games-devel --===============6580722899842218678==--