[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request: add option to allow adjacent ships
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2012-12-24 11:41:53
Message-ID: 20121224114153.20267.63577 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106772/
-----------------------------------------------------------
(Updated Dec. 24, 2012, 11:41 a.m.)
Review request for KDE Games.
Changes
-------
The fourth patch version (I've already dropped locally all the red spaces)
It allows a network game with different adjacent option as the one in the settings.
It shows a chat message showing the adjacent option of the network game
Description
-------
Add the option to allow adjacent ships.
When it is not checked, the ships can not be placed adjacent.
This addresses bug 168659.
http://bugs.kde.org/show_bug.cgi?id=168659
Diffs (updated)
-----
src/battlefield.h ae78166
src/battlefield.cpp 32aa525
src/controller.h bbae7a6
src/controller.cpp 761eda4
src/kbattleship.kcfg b615f30
src/kbattleshipui.rc 7c51ac6
src/mainwindow.cpp 82d9a14
src/message.h 2757cf7
src/message.cpp 59de527
src/networkentity.h c82bfbd
src/networkentity.cpp 5fff5b8
src/playfield.h 56934dc
src/playfield.cpp 61c0ac6
src/protocol.cpp c5cbacc
src/sea.h e76be24
src/sea.cpp de8b697
src/ship.h 5e35f1a
src/ship.cpp 86858d9
Diff: http://git.reviewboard.kde.org/r/106772/diff/
Testing
-------
tested locally.
Thanks,
Jaime Torres Amate
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106772/">http://git.reviewboard.kde.org/r/106772/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2012, 11:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The fourth patch version (I've already dropped locally all the red \
spaces) It allows a network game with different adjacent option as the one in the \
settings. It shows a chat message showing the adjacent option of the network game
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add the option to allow adjacent ships. When it is not checked, the \
ships can not be placed adjacent.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested locally.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=168659">168659</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/battlefield.h <span style="color: grey">(ae78166)</span></li>
<li>src/battlefield.cpp <span style="color: grey">(32aa525)</span></li>
<li>src/controller.h <span style="color: grey">(bbae7a6)</span></li>
<li>src/controller.cpp <span style="color: grey">(761eda4)</span></li>
<li>src/kbattleship.kcfg <span style="color: grey">(b615f30)</span></li>
<li>src/kbattleshipui.rc <span style="color: grey">(7c51ac6)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(82d9a14)</span></li>
<li>src/message.h <span style="color: grey">(2757cf7)</span></li>
<li>src/message.cpp <span style="color: grey">(59de527)</span></li>
<li>src/networkentity.h <span style="color: grey">(c82bfbd)</span></li>
<li>src/networkentity.cpp <span style="color: grey">(5fff5b8)</span></li>
<li>src/playfield.h <span style="color: grey">(56934dc)</span></li>
<li>src/playfield.cpp <span style="color: grey">(61c0ac6)</span></li>
<li>src/protocol.cpp <span style="color: grey">(c5cbacc)</span></li>
<li>src/sea.h <span style="color: grey">(e76be24)</span></li>
<li>src/sea.cpp <span style="color: grey">(de8b697)</span></li>
<li>src/ship.h <span style="color: grey">(5e35f1a)</span></li>
<li>src/ship.cpp <span style="color: grey">(86858d9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106772/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic