From kde-games-devel Fri Aug 17 00:07:37 2012 From: Ian Wadham Date: Fri, 17 Aug 2012 00:07:37 +0000 To: kde-games-devel Subject: Re: [Kde-games-devel] How to close a Review Board request? Message-Id: <4EEE8A6E-2896-4EDF-9D49-935380233C2F () gmail ! com> X-MARC-Message: https://marc.info/?l=kde-games-devel&m=134516217203168 On 17/08/2012, at 7:20 AM, Kevin Krammer wrote: > On Thursday, 2012-08-16, Parker Coates wrote: >> On Thu, Aug 16, 2012 at 6:53 AM, David Edmundson wrote: >>> On Thu, Aug 16, 2012 at 10:50 AM, Ian Wadham wrote: >>>> According to >>>> http://www.reviewboard.org/docs/manual/dev/users/review-requests/closing >>>> / there is a button for closing review requests, but I do not see it >>>> anywhere. >>>> >>>> So how do you close a review request? >>> >>> If it's not yours, you need special priveledges to do it. You can ask >>> someone who has them (me, for example) or file a sysadmin request to >>> get the super powers. >> >> Or easier yet, is to just ask the owner of the review request to close it. >> :) > > Or in a situation where the review request is owned by a contributor without > commit access and you are the developer committing the patch, then you can use > the REVIEW keyword in your commit log to get it closed. > > e.g. > REVIEW: 12345 > will close review request 12345 Thanks guys. I will get the owner, my GSoC student, to close them. Cheers, Ian W. _______________________________________________ kde-games-devel mailing list kde-games-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-games-devel