[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] ksirk and ksudoku still reference Qt3Support
From:       Ian Wadham <ianw3 () tpg ! com ! au>
Date:       2012-05-19 10:06:29
Message-ID: 8F67A494-DA7E-4B0C-BC85-D7BE41EBB2B4 () tpg ! com ! au
[Download RAW message or body]

The unused KSudoku code that references Qt3 has been deleted.

Cheers, Ian W.

On 13/05/2012, at 11:10 PM, Ian Wadham wrote:
> On 13/05/2012, at 7:58 AM, Stefan Majewsky wrote:
>> Qt 5 is going to remove the Qt3Support, so I checked where we are
>> still using it.
>> =

>>   $ ack-grep -l --cpp '\bQ3'
>>   ksudoku/src/gui/export/exportpuzzles.h
>>   ...
>> =

>> KSudoku references Q3ValueList in a typedef. Is this still used? If
>> so, please port to QList.
> =

> That code does not actually get built and has not been worked on for
> about 4 years, when KSudoku was originally released.  I really do not
> know what it does (export what, to where?), but it seems to have some
> printing code in there too, so I am reluctant to just delete it.  It woul=
d be
> nice to restore KSudoku's long-lost Print action one day.  It would be ni=
ce
> too if people would put more comments in their code, but then pigs
> might fly =85 :-)
> =

> What do you think I should do with this whole ksudoku/src/gui/export/
> code directory, Stefan?

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]