[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] KBounce Compilation Problem
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2012-04-24 21:40:25
Message-ID: 1854658.NZMVVhiDGd () xps
[Download RAW message or body]

El Dimarts, 24 d'abril de 2012, a les 18:30:26, Roney Gomes va escriure:
> On 04/24/2012 06:01 PM, Albert Astals Cid wrote:
> > Please when sending patches send patches that do one thing one. Mixing a
> > whitespace change with a "let's include a header so it compiles" change
> > it's not a good idea as it just makes the patch harder to review.
> 
> I disagree. How could it be hard to review? It's just a 17 lines file
> with very small changes. Changes that you rapidly identified and pointed
> in your answer.

It's not a matter of being a small patch of not, it's a matter of principle, a 
patch should have only what you say it has, and if you send a patch that you 
say fixes compilation issues and then changes whitespacing, it's doing 
different stuff of what you said. Nobody says you can't suggest fixing the 
whitespacing, just do it in two separate patches, so if the maintainer doesn't 
want to change it, it's easier for him to apply the patches.

Cheers,
  Albert

> 
> For your information, the change in the line 25 wasn't made by me. I
> don't know why it is highlighted. I've just "included the header to make
> it work" and fixed the whitespace.
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]