[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] libkdegames v5
From:       Parker Coates <parker.coates () gmail ! com>
Date:       2012-02-20 3:26:31
Message-ID: CAEn-cea0PGytA-0wK+WEy+O15EccicJY93TLVgED6MWoQ7OBOA () mail ! gmail ! com
[Download RAW message or body]

On Mon, Jan 30, 2012 at 16:38, Parker Coates wrote:
> On Mon, Jan 30, 2012 at 12:16, Stefan Majewsky wrote:
>> The
>> first obvious point is to move the carddeck stuff into libkcardgame. Wasn't
>> this intended to become public API at some point anyway?
>
> Yes, it was, but
>  a) the API isn't yet documented
>  b) no new games showed up wanting to use libkcardgame to pressure me
> to finish it
>  c) my efforts to port LSkat to libkcardgame never got very far as
> that codebase is very ... um ... interesting.
>  d) my daughter was born and periods of free time longer than 10
> minutes disappeared
>
> Other than d), it's c) that is actually the biggest hurdle, because
> until LSkat is ported the card decks can't be moved into libkcardgame
> and the old card handling code in libkdegames can't be removed.

Okay, so I found some time and have done some clean up.

1. Since LSkat was the only class using the old card loading classes
from libkdegames, I moved the files there.
http://websvn.kde.org/?view=revision&revision=1280805

2. I then modified the classes just moved to LSkat to no longer
support loading frontsides and backsides from different files.
http://websvn.kde.org/?view=revision&revision=1281012

3. Since nobody was using them, I got rid of all the backside graphics
in libkdegames/carddecks/decks.
http://websvn.kde.org/?view=revision&revision=1281014

4. I removed the libkdegames/pics directory as it was only installing
a single file, star.png, that has been unused for a long, long time.
http://websvn.kde.org/?view=revision&revision=1281019

All in all, it amounts to 85 files and 1.3 megabytes removed from
libkdegames, which is pretty good for a few hours work. :)

Parker
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread]