'Re: [Kde-games-devel] Review Request: import TagaroAudio into libkdegames, port Granatier and KGoldR'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request: import TagaroAudio into libkdegames, port Granatier and KGoldR
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2012-02-13 23:24:42
Message-ID: 20120213232442.30566.51753 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6902/#review10671
-----------------------------------------------------------

trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-openal.cpp
<http://svn.reviewboard.kde.org/r/6902/#comment13001>

    As a developer using KGSound i'd like to get a way to get this and the =
other errors of this class up

trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-phonon.cpp
<http://svn.reviewboard.kde.org/r/6902/#comment13002>

    Err, can you elaborate on this? Phonon::AudioOutput has a setVolume

trunk/KDE/kdegames/libkdegames/audio/kgaudioscene.h
<http://svn.reviewboard.kde.org/r/6902/#comment13000>

    Wondering if this should just be a namespace instead of a class with ju=
st statics

trunk/KDE/kdegames/libkdegames/audio/kgsound.h
<http://svn.reviewboard.kde.org/r/6902/#comment13005>

    You might want to Q_DISABLE_COPY this class

trunk/KDE/kdegames/libkdegames/audio/kgsound.h
<http://svn.reviewboard.kde.org/r/6902/#comment13004>

    If you are going the properties route i'd might make sense to add NOTIF=
Y signal for when they change

- Albert Astals Cid

On Feb. 13, 2012, 8:37 p.m., Stefan Majewsky wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6902/
> -----------------------------------------------------------
> =

> (Updated Feb. 13, 2012, 8:37 p.m.)
> =

> =

> Review request for KDE Games and Ian Wadham.
> =

> =

> Description
> -------
> =

> As the first new component in libkdegames v5, I'm adding TagaroAudio whic=
h has already resided in the kdegames source tree via private static copies=
 in Granatier and KGoldRunner. This patch ports both to the new classes in =
libkdegames.
> =

> Because the Tagaro brand name need be eliminated as the code is imported =
into libkdegames, I have removed the Tagaro namespace and added a "Kg" pref=
ix to the class names, which are now KgAudioScene and KgSound. I know that =
this is a departure from the current "KGameFoo" naming scheme, see my mail =
to the kde-games-devel@ about this.
> =

> I could not get reviewboard to accept my patch including the various file=
s I deleted, so here's a list of all deleted stuff:
> * granatier/cmake/modules/FindSndFile.cmake (now in <toplevel>/cmake/modu=
les)
> * granatier/src/TagaroAudio
> * granatier/src/granatiersound.{h,cpp} (Tagaro::Sound is now used directl=
y instead of the thin wrapper GranatierSound)
> * kgoldrunner/cmake/modules/FindSndFile.cmake (see above; why did we have=
 two copies of this anyway?)
> * kgoldrunner/src/TagaroAudio
> * kgoldrunner/src/kgrsoundbank.{h,cpp} (after I removed the ifdefs, it wa=
s not used anywhere, so I figured it's about time to retire this class).
> =

> I checked the log of the static copies of TagaroAudio in Granatier and KG=
oldRunner, and imported a patch from Mathias Kraus in granatier/src/Tagaro =
into the KgAudio code.
> =

> =

> Diffs
> -----
> =

>   trunk/KDE/kdegames/CMakeLists.txt 1279940 =

>   trunk/KDE/kdegames/cmake/modules/FindSndFile.cmake PRE-CREATION =

>   trunk/KDE/kdegames/granatier/CMakeLists.txt 1279940 =

>   trunk/KDE/kdegames/granatier/src/CMakeLists.txt 1279940 =

>   trunk/KDE/kdegames/granatier/src/game.h 1279940 =

>   trunk/KDE/kdegames/granatier/src/game.cpp 1279940 =

>   trunk/KDE/kdegames/kgoldrunner/CMakeLists.txt 1279940 =

>   trunk/KDE/kdegames/kgoldrunner/src/CMakeLists.txt 1279940 =

>   trunk/KDE/kdegames/kgoldrunner/src/kgoldrunner.cpp 1279940 =

>   trunk/KDE/kdegames/kgoldrunner/src/kgrgame.h 1279940 =

>   trunk/KDE/kdegames/kgoldrunner/src/kgrgame.cpp 1279940 =

>   trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.h 1279940 =

>   trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.cpp 1279940 =

>   trunk/KDE/kdegames/kgoldrunner/src/main.cpp 1279940 =

>   trunk/KDE/kdegames/libkdegames/CMakeLists.txt 1279940 =

>   trunk/KDE/kdegames/libkdegames/audio/CMakeLists.txt PRE-CREATION =

>   trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-openal.cpp PRE-CREATI=
ON =

>   trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-phonon.cpp PRE-CREATI=
ON =

>   trunk/KDE/kdegames/libkdegames/audio/kgaudioscene.h PRE-CREATION =

>   trunk/KDE/kdegames/libkdegames/audio/kgopenalruntime_p.h PRE-CREATION =

>   trunk/KDE/kdegames/libkdegames/audio/kgsound-openal.cpp PRE-CREATION =

>   trunk/KDE/kdegames/libkdegames/audio/kgsound-phonon.cpp PRE-CREATION =

>   trunk/KDE/kdegames/libkdegames/audio/kgsound.h PRE-CREATION =

>   trunk/KDE/kdegames/libkdegames/includes/CMakeLists.txt 1279940 =

>   trunk/KDE/kdegames/libkdegames/includes/KgAudioScene PRE-CREATION =

>   trunk/KDE/kdegames/libkdegames/includes/KgSound PRE-CREATION =

> =

> Diff: http://svn.reviewboard.kde.org/r/6902/diff/
> =

> =

> Testing
> -------
> =

> Sound playback works in Granatier and KGoldRunner.
> =

> =

> Thanks,
> =

> Stefan Majewsky
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6902/">http://svn.reviewboard.kde.org/r/6902/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6902/diff/1/?file=47623#file47623line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-openal.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void KgOpenALRuntime::configureListener()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">103</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="tb">	</span><span class="n">kDebug</span><span \
class="p">()</span> <span class="o">&lt;&lt;</span> <span class="s">&quot;Failed to \
setup OpenAL listener: Error code&quot;</span> <span class="o">&lt;&lt;</span> <span \
class="n">error</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As a \
developer using KGSound i&#39;d like to get a way to get this and the other errors of \
this class up</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6902/diff/1/?file=47624#file47624line46" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-phonon.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void KgAudioScene::setVolume(qreal volume)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">46</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="n">Q_UNUSED</span><span class="p">(</span><span \
class="n">volume</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Err, can \
you elaborate on this? Phonon::AudioOutput has a setVolume</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6902/diff/1/?file=47625#file47625line44" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdegames/libkdegames/audio/kgaudioscene.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">44</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">class</span> <span class="n">KDEGAMES_EXPORT</span> <span \
class="n">KgAudioScene</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wondering \
if this should just be a namespace instead of a class with just statics</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6902/diff/1/?file=47629#file47629line45" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdegames/libkdegames/audio/kgsound.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">class PlaybackEvent;</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">45</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">class</span> <span class="n">KDEGAMES_EXPORT</span> <span \
class="n">KgSound</span> <span class="o">:</span> <span class="n">public</span> <span \
class="n">QObject</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You might \
want to Q_DISABLE_COPY this class</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6902/diff/1/?file=47629#file47629line48" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdegames/libkdegames/audio/kgsound.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">class PlaybackEvent;</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">48</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="n">Q_PROPERTY</span><span class="p">(</span><span \
class="n">KgSound</span><span class="o">::</span><span class="n">PlaybackType</span> \
<span class="n">playbackType</span> <span class="n">READ</span> <span \
class="n">playbackType</span> <span class="n">WRITE</span> <span \
class="n">setPlaybackType</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you are \
going the properties route i&#39;d might make sense to add NOTIFY signal for when \
they change</pre> </div>
<br />

<p>- Albert</p>

<br />
<p>On February 13th, 2012, 8:37 p.m., Stefan Majewsky wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Games and Ian Wadham.</div>
<div>By Stefan Majewsky.</div>

<p style="color: grey;"><i>Updated Feb. 13, 2012, 8:37 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As the first new component in libkdegames v5, I&#39;m adding TagaroAudio \
which has already resided in the kdegames source tree via private static copies in \
Granatier and KGoldRunner. This patch ports both to the new classes in libkdegames.

Because the Tagaro brand name need be eliminated as the code is imported into \
libkdegames, I have removed the Tagaro namespace and added a &quot;Kg&quot; prefix to \
the class names, which are now KgAudioScene and KgSound. I know that this is a \
departure from the current &quot;KGameFoo&quot; naming scheme, see my mail to the \
kde-games-devel@ about this.

I could not get reviewboard to accept my patch including the various files I deleted, \
                so here&#39;s a list of all deleted stuff:
* granatier/cmake/modules/FindSndFile.cmake (now in &lt;toplevel&gt;/cmake/modules)
* granatier/src/TagaroAudio
* granatier/src/granatiersound.{h,cpp} (Tagaro::Sound is now used directly instead of \
                the thin wrapper GranatierSound)
* kgoldrunner/cmake/modules/FindSndFile.cmake (see above; why did we have two copies \
                of this anyway?)
* kgoldrunner/src/TagaroAudio
* kgoldrunner/src/kgrsoundbank.{h,cpp} (after I removed the ifdefs, it was not used \
anywhere, so I figured it&#39;s about time to retire this class).

I checked the log of the static copies of TagaroAudio in Granatier and KGoldRunner, \
and imported a patch from Mathias Kraus in granatier/src/Tagaro into the KgAudio \
code.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Sound playback works in Granatier and KGoldRunner.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdegames/CMakeLists.txt <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/cmake/modules/FindSndFile.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/granatier/CMakeLists.txt <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/granatier/src/CMakeLists.txt <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/granatier/src/game.h <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/granatier/src/game.cpp <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/kgoldrunner/CMakeLists.txt <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/kgoldrunner/src/CMakeLists.txt <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/kgoldrunner/src/kgoldrunner.cpp <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/kgoldrunner/src/kgrgame.h <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/kgoldrunner/src/kgrgame.cpp <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.h <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.cpp <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/kgoldrunner/src/main.cpp <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/CMakeLists.txt <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/audio/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-openal.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-phonon.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/audio/kgaudioscene.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/audio/kgopenalruntime_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/audio/kgsound-openal.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/audio/kgsound-phonon.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/audio/kgsound.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/includes/CMakeLists.txt <span style="color: \
grey">(1279940)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/includes/KgAudioScene <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdegames/libkdegames/includes/KgSound <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6902/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 