[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request: remove KGGZ dependency from KBattleShip (aka Naval Battle)
From: "Paolo Capriotti" <p.capriotti () gmail ! com>
Date: 2012-02-09 15:29:58
Message-ID: 20120209152958.22904.83015 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6895/#review10667
-----------------------------------------------------------
You removed too much. Multiplayer doesn't require GGZ libraries, and was th=
ere since before GGZ was integrated.
- Paolo Capriotti
On Feb. 8, 2012, 11:43 p.m., Stefan Majewsky wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6895/
> -----------------------------------------------------------
> =
> (Updated Feb. 8, 2012, 11:43 p.m.)
> =
> =
> Review request for KDE Games and Paolo Capriotti.
> =
> =
> Description
> -------
> =
> As discussed on kde-games-devel@, I'm starting to remove KGGZ from kdegam=
es. This patch drops all GGZ-related code from KBattleShip. I have been car=
eful not to leave any unused (and thus untestable) code paths, so the patch=
has grown to a massive size of +46/-3082. The patch consists of 11 git-svn=
commits.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdegames/kbattleship/src/CMakeLists.txt 1278817 =
> trunk/KDE/kdegames/kbattleship/src/aientity.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/battlefield.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/battlefield.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/battlefieldview.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/battlefieldview.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/button.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/button.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/chatwidget.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/chatwidget.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/controller.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/controller.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/entity.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/entity.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/kbattleship.kcfg 1278817 =
> trunk/KDE/kdegames/kbattleship/src/kbattleship.protocol 1278817 =
> trunk/KDE/kdegames/kbattleship/src/kbattleshipui.rc 1278817 =
> trunk/KDE/kdegames/kbattleship/src/main.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/mainwindow.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/mainwindow.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/message.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/message.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/module.dsc 1278817 =
> trunk/KDE/kdegames/kbattleship/src/networkdialog.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/networkdialog.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/networkentity.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/networkentity.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/playerentity.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/playerentity.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/playfield.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/playfield.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/protocol.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/protocol.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/sea.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/sea.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/seaview.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/seaview.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/settings.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/settings.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/settings.kcfgc PRE-CREATION =
> trunk/KDE/kdegames/kbattleship/src/settingsbase.kcfgc 1278817 =
> trunk/KDE/kdegames/kbattleship/src/simplemenu.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/simplemenu.cpp 1278817 =
> trunk/KDE/kdegames/kbattleship/src/uientity.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/welcomescreen.h 1278817 =
> trunk/KDE/kdegames/kbattleship/src/welcomescreen.cpp 1278817 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6895/diff/diff
> =
> =
> Testing
> -------
> =
> Played the game a few times, both with easy AI (to test winning) and hard=
AI (to test losing). Everything works fine.
> =
> =
> Thanks,
> =
> Stefan Majewsky
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6895/">http://svn.reviewboard.kde.org/r/6895/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You removed too much. \
Multiplayer doesn't require GGZ libraries, and was there since before GGZ was \
integrated.</pre> <br />
<p>- Paolo</p>
<br />
<p>On February 8th, 2012, 11:43 p.m., Stefan Majewsky wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games and Paolo Capriotti.</div>
<div>By Stefan Majewsky.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2012, 11:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed on kde-games-devel@, I'm starting to remove KGGZ from \
kdegames. This patch drops all GGZ-related code from KBattleShip. I have been careful \
not to leave any unused (and thus untestable) code paths, so the patch has grown to a \
massive size of +46/-3082. The patch consists of 11 git-svn commits.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Played the game a few times, both with easy AI (to test winning) and \
hard AI (to test losing). Everything works fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/kbattleship/src/CMakeLists.txt <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/aientity.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/battlefield.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/battlefield.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/battlefieldview.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/battlefieldview.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/button.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/button.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/chatwidget.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/chatwidget.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/controller.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/controller.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/entity.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/entity.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/kbattleship.kcfg <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/kbattleship.protocol <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/kbattleshipui.rc <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/main.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/mainwindow.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/mainwindow.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/message.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/message.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/module.dsc <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/networkdialog.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/networkdialog.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/networkentity.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/networkentity.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/playerentity.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/playerentity.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/playfield.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/playfield.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/protocol.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/protocol.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/sea.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/sea.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/seaview.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/seaview.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/settings.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/settings.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/settings.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/settingsbase.kcfgc <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/simplemenu.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/simplemenu.cpp <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/uientity.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/welcomescreen.h <span style="color: \
grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/welcomescreen.cpp <span style="color: \
grey">(1278817)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6895/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic