[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request: Konquest: Implement standing
From: "Pierre Ducroquet" <pinaraf () pinaraf ! info>
Date: 2011-10-22 10:07:14
Message-ID: 20111022100714.29356.20074 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 21, 2011, 3:59 p.m., Jeffrey Kelling wrote:
> > It would be nice to have this feature in 4.8, so is anyone opposed to me \
> > committing it before the soft feature freeze (especially Pierre) ?
> > I guess it would be nice to be able to change the number of ships of an existing \
> > standing order, but this would require some major changes around the \
> > initialisation of the fleet dialogue (the dialogue would have to get write access \
> > to the players ship list) and I do not know if Pierre would be ok with this.
> > Apart from this would implement a feature requested in 2004, with no regressions.
> >
> > Regards,
> >
> > Jeffrey
I'm ok with commiting this.
As many may have noticed, I've been short on free-time in the last weeks… So better \
merge it asap, and if there is any non-spotted bug, fix it during the beta \
releases…
- Pierre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6805/#review10443
-----------------------------------------------------------
On Sept. 18, 2011, 7:19 p.m., Jeffrey Kelling wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6805/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2011, 7:19 p.m.)
>
>
> Review request for KDE Games and Pierre Ducroquet.
>
>
> Description
> -------
>
> This patch implements standing orders, i.e. orders that are repeated each turn if \
> possible. Standing orders are issued the same way as normal order, additionally the \
> added check box has to be checked. They are also removed the same way as normal \
> orders (in the fleet overview). The orders are executed at the end of turn if \
> enough ships are available, if not a message is issued. If the Planet is no longer \
> under the players control the order is deleted.
> The number of ships that will be send due to standing order from a planet is \
> displayed in that planets planet info (to its owner only).
>
> This addresses bug 87882.
> https://bugs.kde.org/show_bug.cgi?id=87882
>
>
> Diffs
> -----
>
> trunk/KDE/kdegames/konquest/dialogs/fleetdlg.h 1254115
> trunk/KDE/kdegames/konquest/dialogs/fleetdlg.cc 1254115
> trunk/KDE/kdegames/konquest/game.h 1254115
> trunk/KDE/kdegames/konquest/game.cpp 1254115
> trunk/KDE/kdegames/konquest/gameview.h 1254115
> trunk/KDE/kdegames/konquest/gameview.cc 1254115
> trunk/KDE/kdegames/konquest/map/mapitems.cc 1254115
> trunk/KDE/kdegames/konquest/planet.cc 1254115
> trunk/KDE/kdegames/konquest/players/player.h 1254115
> trunk/KDE/kdegames/konquest/players/player.cpp 1254115
>
> Diff: http://svn.reviewboard.kde.org/r/6805/diff/diff
>
>
> Testing
> -------
>
> Played the game, issued standing orders, ...
>
>
> Screenshots
> -----------
>
> Spawn Fleet
> http://svn.reviewboard.kde.org/r/6805/s/621/
> Fleet Overview
> http://svn.reviewboard.kde.org/r/6805/s/622/
> Ships needed for standing orders in planet info
> http://svn.reviewboard.kde.org/r/6805/s/623/
>
>
> Thanks,
>
> Jeffrey Kelling
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6805/">http://svn.reviewboard.kde.org/r/6805/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 21st, 2011, 3:59 p.m., <b>Jeffrey \
Kelling</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It would be nice to have this feature in 4.8, so is anyone opposed to me \
committing it before the soft feature freeze (especially Pierre) ?
I guess it would be nice to be able to change the number of ships of an existing \
standing order, but this would require some major changes around the initialisation \
of the fleet dialogue (the dialogue would have to get write access to the players \
ship list) and I do not know if Pierre would be ok with this.
Apart from this would implement a feature requested in 2004, with no regressions.
Regards,
Jeffrey</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm ok with \
commiting this. As many may have noticed, I've been short on free-time in the \
last weeks… So better merge it asap, and if there is any non-spotted bug, fix it \
during the beta releases…</pre> <br />
<p>- Pierre</p>
<br />
<p>On September 18th, 2011, 7:19 p.m., Jeffrey Kelling wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games and Pierre Ducroquet.</div>
<div>By Jeffrey Kelling.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2011, 7:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements standing orders, i.e. orders that are repeated \
each turn if possible. Standing orders are issued the same way as normal order, \
additionally the added check box has to be checked. They are also removed the same \
way as normal orders (in the fleet overview). The orders are executed at the end of \
turn if enough ships are available, if not a message is issued. If the Planet is no \
longer under the players control the order is deleted.
The number of ships that will be send due to standing order from a planet is \
displayed in that planets planet info (to its owner only).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Played the game, issued standing orders, ...</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=87882">87882</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/konquest/dialogs/fleetdlg.h <span style="color: \
grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/dialogs/fleetdlg.cc <span style="color: \
grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/game.h <span style="color: \
grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/game.cpp <span style="color: \
grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/gameview.h <span style="color: \
grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/gameview.cc <span style="color: \
grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/map/mapitems.cc <span style="color: \
grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/planet.cc <span style="color: \
grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/players/player.h <span style="color: \
grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/players/player.cpp <span style="color: \
grey">(1254115)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6805/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6805/s/621/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/09/13/standingOrders_400x100.png" \
style="border: 1px black solid;" alt="Spawn Fleet" /></a>
<a href="http://svn.reviewboard.kde.org/r/6805/s/622/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/09/13/standingOrdersFleetOverView_400x100.png" \
style="border: 1px black solid;" alt="Fleet Overview" /></a>
<a href="http://svn.reviewboard.kde.org/r/6805/s/623/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/09/13/standingOrdersInPlanetInfo_400x100.png" \
style="border: 1px black solid;" alt="Ships needed for standing orders in planet \
info" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic