[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: [Kde-games-devel] Re: Review Request: Port KLines to KGameRenderer
From: "Frederik Schwarzer" <schwarzerf () gmail ! com>
Date: 2011-05-27 7:37:45
Message-ID: 20110527073745.5871.72376 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 20, 2011, 10:04 a.m., Frederik Schwarzer wrote:
> > Ok, it applies, compiles and runs smoothly here.
> > I cannot judge KGameRenderer-wise, though, since I did not have a look =
at its API yet.
> > But with so many OKs, I think it's save to commit, no? :)
> > =
> > One word though. KDELibs coding style is not a requirement for code in =
the Games module. While I try to use it, some do not. So if a game is maint=
ained by someone else, please ask them for their opinion on the style. And =
please try to avoid mixing actual code changes with style changes.
> > =
> > I do not know if this applies to KLines or if you already asked. I just=
meant this generally.
> =
> Lindsay Mathieson wrote:
> Thanks Frederik, in retrospect it was cheeky to apply astyle to the c=
ode, my apologies.
> =
> If no one objects I'll go ahead and commit
Closing as Submitted. See r1229676.
- Frederik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5399/#review10070
-----------------------------------------------------------
On April 20, 2011, 5 a.m., Lindsay Mathieson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5399/
> -----------------------------------------------------------
> =
> (Updated April 20, 2011, 5 a.m.)
> =
> =
> Review request for KDE Games.
> =
> =
> Summary
> -------
> =
> Updates klines to use KGameRenderer and KGameRenderedItem in place of QSv=
gRenderer and QGraphicsPixmapItem
> Removes KPixmapCache usage
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdegames/klines/animator.cpp 1228557 =
> /trunk/KDE/kdegames/klines/ballitem.h 1228557 =
> /trunk/KDE/kdegames/klines/ballitem.cpp 1228557 =
> /trunk/KDE/kdegames/klines/klines.cpp 1228557 =
> /trunk/KDE/kdegames/klines/previewitem.cpp 1228557 =
> /trunk/KDE/kdegames/klines/renderer.h 1228557 =
> /trunk/KDE/kdegames/klines/renderer.cpp 1228557 =
> /trunk/KDE/kdegames/klines/scene.cpp 1228557 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5399/diff
> =
> =
> Testing
> -------
> =
> Playing game
> Changing themes
> Resizing game
> Comparison with original
> =
> =
> Thanks,
> =
> Lindsay
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5399/">http://svn.reviewboard.kde.org/r/5399/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 20th, 2011, 10:04 a.m., <b>Frederik \
Schwarzer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ok, it applies, compiles and runs smoothly here. I cannot judge \
KGameRenderer-wise, though, since I did not have a look at its API yet. But with so \
many OKs, I think it's save to commit, no? :)
One word though. KDELibs coding style is not a requirement for code in the Games \
module. While I try to use it, some do not. So if a game is maintained by someone \
else, please ask them for their opinion on the style. And please try to avoid mixing \
actual code changes with style changes.
I do not know if this applies to KLines or if you already asked. I just meant this \
generally.</pre> </blockquote>
<p>On April 29th, 2011, 1:38 a.m., <b>Lindsay Mathieson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks Frederik, in \
retrospect it was cheeky to apply astyle to the code, my apologies.
If no one objects I'll go ahead and commit</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Closing as Submitted. \
See r1229676.</pre> <br />
<p>- Frederik</p>
<br />
<p>On April 20th, 2011, 5 a.m., Lindsay Mathieson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Lindsay Mathieson.</div>
<p style="color: grey;"><i>Updated April 20, 2011, 5 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updates klines to use KGameRenderer and KGameRenderedItem in place of \
QSvgRenderer and QGraphicsPixmapItem Removes KPixmapCache usage</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Playing game Changing themes
Resizing game
Comparison with original</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/klines/animator.cpp <span style="color: \
grey">(1228557)</span></li>
<li>/trunk/KDE/kdegames/klines/ballitem.h <span style="color: \
grey">(1228557)</span></li>
<li>/trunk/KDE/kdegames/klines/ballitem.cpp <span style="color: \
grey">(1228557)</span></li>
<li>/trunk/KDE/kdegames/klines/klines.cpp <span style="color: \
grey">(1228557)</span></li>
<li>/trunk/KDE/kdegames/klines/previewitem.cpp <span style="color: \
grey">(1228557)</span></li>
<li>/trunk/KDE/kdegames/klines/renderer.h <span style="color: \
grey">(1228557)</span></li>
<li>/trunk/KDE/kdegames/klines/renderer.cpp <span style="color: \
grey">(1228557)</span></li>
<li>/trunk/KDE/kdegames/klines/scene.cpp <span style="color: \
grey">(1228557)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5399/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic