'[Kde-games-devel] Re: Review Request: Remove unused gifts from'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    [Kde-games-devel] Re: Review Request: Remove unused gifts from
From:       "Frederik Schwarzer" <schwarzerf () gmail ! com>
Date:       2011-04-08 19:47:54
Message-ID: 20110408194754.12427.55809 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On April 3, 2011, 9:47 a.m., Julian Helfferich wrote:
> > I assume there were plans to include these gift types when the default =
levelset of KBreakout was created but since the old loadLevel() function di=
d not issue any error messages about unsupported gift types they fell into =
oblivion. It would be nice, if Fela could comment on this. I would be happy=
 with removing these lines from the levelset.
> =

> Frederik Schwarzer wrote:
>     I wrote him an email.

Since Fela did not answer yet and already said about a year ago, that his f=
ree time went away for other stuff (seriously, ruby?! ;)), I will commmit t=
his in the next few days, if no objections occur.
I can see no harm in this change and it removes some confusion in times of =
coming level editors, since this file will be used as some kind of referenc=
e, I suppose.

- Frederik

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6655/#review10047
-----------------------------------------------------------

On April 1, 2011, 2:38 a.m., Frederik Schwarzer wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6655/
> -----------------------------------------------------------
> =

> (Updated April 1, 2011, 2:38 a.m.)
> =

> =

> Review request for KDE Games.
> =

> =

> Summary
> -------
> =

> This patch removes all unused gifts from the default level set. Neither a=
re they used in any of the current themes nor handled in the source code.
> =

> Or were there other plans for those gifts?
> =

> =

> Diffs
> -----
> =

>   /trunk/KDE/kdegames/kbreakout/levelsets/default.levelset 1226683 =

> =

> Diff: http://svn.reviewboard.kde.org/r/6655/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Frederik
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6655/">http://svn.reviewboard.kde.org/r/6655/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On April 3rd, 2011, 9:47 a.m., <b>Julian \
Helfferich</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I assume there were plans to include these gift types when the default \
levelset of KBreakout was created but since the old loadLevel() function did not \
issue any error messages about unsupported gift types they fell into oblivion. It \
would be nice, if Fela could comment on this. I would be happy with removing these \
lines from the levelset.</pre>  </blockquote>

 <p>On April 3rd, 2011, 2:02 p.m., <b>Frederik Schwarzer</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wrote him an \
email.</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since Fela did not \
answer yet and already said about a year ago, that his free time went away for other \
stuff (seriously, ruby?! ;)), I will commmit this in the next few days, if no \
objections occur. I can see no harm in this change and it removes some confusion in \
times of coming level editors, since this file will be used as some kind of \
reference, I suppose.</pre> <br />

<p>- Frederik</p>

<br />
<p>On April 1st, 2011, 2:38 a.m., Frederik Schwarzer wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Frederik Schwarzer.</div>

<p style="color: grey;"><i>Updated April 1, 2011, 2:38 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch removes all unused gifts from the default level set. Neither \
are they used in any of the current themes nor handled in the source code.

Or were there other plans for those gifts?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdegames/kbreakout/levelsets/default.levelset <span style="color: \
grey">(1226683)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6655/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 