From kde-games-devel Thu Oct 28 13:16:06 2010 From: "Antonis Tsiapaliokas" Date: Thu, 28 Oct 2010 13:16:06 +0000 To: kde-games-devel Subject: [Kde-games-devel] Re: Review Request: fix 215352 bug Message-Id: <20101028131606.29837.16433 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-games-devel&m=128827188306434 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1786893530==" --===============1786893530== Content-Type: multipart/alternative; boundary="===============5808176562240174414==" --===============5808176562240174414== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5682/ ----------------------------------------------------------- (Updated 2010-10-28 13:16:06.487374) Review request for KDE Games. Changes ------- Hello I have tried the previous patch with the easy layout but it didn't work... = Because the animation is the last thing which is called after you win the g= ame and it refresh the undo button... So i have write a new patch and i hav= e place it, into a different place and now it works fine... In my opinion t= his the best way to solve this bug without making big changes... If you don= 't like it or you think that it is to simple then let me know. :) I can com= pile the program without any trouble... = Summary ------- Hello This is my first effort to help the kdegames,so i am sorry if i have done s= omething wrong...This bug regards the kmahjongg game.This patch is fixing t= he bug 215352.All the information that you will need, are located into the = bug report... With a few words, after someone wins, the undo button is stil= l enable and full functional... This addresses bug 215352. https://bugs.kde.org/show_bug.cgi?id=3D215352 Diffs (updated) ----- trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1190650 = Diff: http://svn.reviewboard.kde.org/r/5682/diff Testing ------- The kmahjongg game compiles and runs fine.But there is a problem,which it w= ill sound to you very silly... I have create the patch but i cannot win the= game so i cannot test my patch... But i have found another way to test my = patch, and there works fine... If you look at the kmahjongg.cpp (it is loca= ted into the kdegames/kmahjongg) at the lines 174("undoAction =3D KStandard= GameAction::undo(this, SLOT(undo()), actionCollection());") and 119-120 (co= nnect( bw, SIGNAL( gameOver(unsigned short , unsigned short)), this,SLOT( g= ameOver(unsigned short , unsigned short)));) those two functions are connec= ted with the bw object.So if i add the code from my patch into the KMahjong= g::undo() method and after i make 10 moves into the game, i will be able to= undo only the last one because when i hit the undo button then, the code f= rom my patch is called and the undo button is becoming dissable (from enabl= e). So instead of adding the code into the KMahjongg::undo(), if i add it, = into the KMahjongg::gameOver() then it should work fine... I know that this= is very wrong, as regards the testing for my patch but i could not find so= mething better... Thanks, Antonis --===============5808176562240174414== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5682/

Review request for KDE Games.

By Antonis Tsiapaliokas.

Updated 2010-10-28 13:16:06.487374

Changes

Hello

I have tried the previous patch with the easy layout but it didn't work=
... Because the animation is the last thing which is called after you win t=
he game and it refresh the undo button... So i have write a new patch and i=
 have place it, into a different place and now it works fine... In my opini=
on this the best way to solve this bug without making big changes... If you=
 don't like it or you think that it is to simple then let me know. :) I=
 can compile the program without any trouble...

Descripti= on

Hello

This is my first effort to help the kdegames,so i am sorry if i have done s=
omething wrong...This bug regards the kmahjongg game.This patch is fixing t=
he bug 215352.All the information that you will need, are located into the =
bug report... With a few words, after someone wins, the undo button is stil=
l enable and full functional...

Testing <= /h1>

The kmahjongg game compiles and runs fine.But there is a pro=
blem,which it will sound to you very silly... I have create the patch but i=
 cannot win the game so i cannot test my patch... But i have found another =
way to test my patch, and there works fine... If you look at the kmahjongg.=
cpp (it is located into the kdegames/kmahjongg) at the lines 174("undo=
Action =3D KStandardGameAction::undo(this, SLOT(undo()), actionCollection()=
);") and 119-120 (connect( bw, SIGNAL( gameOver(unsigned short , unsig=
ned short)), this,SLOT( gameOver(unsigned short , unsigned short)));) those=
 two functions are connected with the bw object.So if i add the code from m=
y patch into the KMahjongg::undo() method and after i make 10 moves into th=
e game, i will be able to undo only the last one because when i hit the und=
o button then, the code from my patch is called and the undo button is beco=
ming dissable (from enable). So instead of adding the code into the KMahjon=
gg::undo(), if i add it, into the KMahjongg::gameOver() then it should work=
 fine... I know that this is very wrong, as regards the testing for my patc=
h but i could not find something better...

Bugs: 215352

Diffs= (updated)

trunk/KDE/kdegames/kmahjongg/boardwidget.cpp (1190650)

--===============5808176562240174414==-- --===============1786893530== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-games-devel mailing list kde-games-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-games-devel --===============1786893530==--